Skip to content

[Merged by Bors] - feat: SMul instance for AddSubmonoid and lemmas#18096

Closed
alreadydone wants to merge 3 commits intomasterfrom
AddSubmonoid.mul
Closed

[Merged by Bors] - feat: SMul instance for AddSubmonoid and lemmas#18096
alreadydone wants to merge 3 commits intomasterfrom
AddSubmonoid.mul

Conversation

@alreadydone
Copy link
Copy Markdown
Contributor

@alreadydone alreadydone commented Oct 22, 2024

  • Introduce a SMul instance for two AddSubmonoids and provide lemmas

  • Introduce a Mul instance for AddSubgroup

  • Prove lemmas for the existing Mul instance on AddSubmonoid, which are generalized from corresponding Submodule lemmas

Open in Gitpod

@alreadydone alreadydone added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-algebra Algebra (groups, rings, fields, etc) labels Oct 22, 2024
@alreadydone alreadydone mentioned this pull request Oct 22, 2024
Closed
4 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 22, 2024 •
edited
Loading

PR summary 51cc9f4226

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ iSup_mul
+ mul
+ mul_iSup
+ mul_sup
+ mul_toAddSubmonoid
+ smul
+ smul_induction_on
+ smul_le
+ smul_le_smul
+ smul_mem_smul
+ sup_mul

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Oct 23, 2024
eric-wieser
eric-wieser reviewed Oct 23, 2024
View reviewed changes
eric-wieser
eric-wieser reviewed Oct 23, 2024
View reviewed changes
jcommelin
jcommelin reviewed Oct 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 24, 2024

✌️ alreadydone can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Oct 24, 2024
@alreadydone @jcommelin
blank lines
51cc9f4 
Co-authored-by: Johan Commelin <johan@commelin.net>
alreadydone
alreadydone commented Oct 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Oct 24, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 24, 2024
@alreadydone
feat: SMul instance for AddSubmonoid and lemmas (#18096)
62a047f 
+ Introduce a `SMul` instance for two `AddSubmonoid`s and provide lemmas

+ Introduce a `Mul` instance for `AddSubgroup`

+ Prove lemmas for the existing `Mul` instance on `AddSubmonoid`, which are generalized from corresponding `Submodule` lemmas
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 24, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: SMul instance for AddSubmonoid and lemmas [Merged by Bors] - feat: SMul instance for AddSubmonoid and lemmas Oct 24, 2024
@mathlib-bors mathlib-bors bot closed this Oct 24, 2024
@mathlib-bors mathlib-bors bot deleted the AddSubmonoid.mul branch October 24, 2024 16:57
YaelDillies added a commit that referenced this pull request Apr 8, 2025
@YaelDillies
chore(Algebra/Group/Subgroup/Pointwise): don't import GroupWithZero
26a5ffb 
Instead, move the `GroupWithZero` and `Ring` content of `Algebra.Group.Submonoid.Pointwise` and `Algebra.Group.Subgroup.Pointwise` to:
* `Algebra.GroupWithZero.Submonoid`. See leanprover-community/mathlib3#9359 for the copyright.
* `Algebra.GroupWithZero.Subgroup`. See leanprover-community/mathlib3#9359 for the copyright.
* `Algebra.Ring.Submonoid`. See leanprover-community/mathlib3#9359 for the copyright.
* `Algebra.Ring.Subgroup`. See #18096 for the copyright
@YaelDillies YaelDillies mentioned this pull request Apr 8, 2025
Closed
mathlib-bors bot pushed a commit that referenced this pull request Apr 9, 2025
@YaelDillies
chore(Algebra/Group/Subgroup/Pointwise): don't import GroupWithZero (…
899a550 
…#23832)

Instead, move the `GroupWithZero` and `Ring` content of `Algebra.Group.Submonoid.Pointwise` and `Algebra.Group.Subgroup.Pointwise` to:
* `Algebra.GroupWithZero.Submonoid.Pointwise`. See leanprover-community/mathlib3#9359 for the copyright.
* `Algebra.GroupWithZero.Subgroup`. See leanprover-community/mathlib3#9359 for the copyright.
* `Algebra.Ring.Submonoid.Pointwise`. See leanprover-community/mathlib3#9359 for the copyright.
* `Algebra.Ring.Subgroup`. See #18096 for the copyright
tannerduve pushed a commit that referenced this pull request May 13, 2025
@YaelDillies @tannerduve
chore(Algebra/Group/Subgroup/Pointwise): don't import GroupWithZero (…
a053147 
…#23832)

Instead, move the `GroupWithZero` and `Ring` content of `Algebra.Group.Submonoid.Pointwise` and `Algebra.Group.Subgroup.Pointwise` to:
* `Algebra.GroupWithZero.Submonoid.Pointwise`. See leanprover-community/mathlib3#9359 for the copyright.
* `Algebra.GroupWithZero.Subgroup`. See leanprover-community/mathlib3#9359 for the copyright.
* `Algebra.Ring.Submonoid.Pointwise`. See leanprover-community/mathlib3#9359 for the copyright.
* `Algebra.Ring.Subgroup`. See #18096 for the copyright
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@jcommelin jcommelin jcommelin left review comments

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alreadydone @eric-wieser @jcommelin