[Merged by Bors] - refactor: redefine Module.annihilator using RingHom.ker#18094
Closed
alreadydone wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - refactor: redefine Module.annihilator using RingHom.ker#18094alreadydone wants to merge 2 commits intomasterfrom
Module.annihilator using RingHom.ker#18094alreadydone wants to merge 2 commits intomasterfrom
Conversation
PR summary 7cf802ef20
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.Ideal.Colon | 948 | 949 | +1 (+0.11%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.RingTheory.Ideal.Colon |
1 |
Declarations diff
+ LinearEquiv.annihilator_eq
+ LinearMap.annihilator_le_of_injective
+ LinearMap.annihilator_le_of_surjective
+ Module.annihilator
+ Module.mem_annihilator
- _root_.LinearEquiv.annihilator_eq
- _root_.LinearMap.annihilator_le_of_injective
- _root_.LinearMap.annihilator_le_of_surjective
- _root_.Module.annihilator
- _root_.Module.mem_annihilator
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
4 tasks
Contributor
|
✌️ alreadydone can now approve this pull request. To approve and merge a pull request, simply reply with |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
The original definition `LinearMap.ker (LinearMap.lsmul R M)` doesn't work in the noncommutative setting, because `lsmul` isn't `R`-linear if `R` is noncommutative, and also `LinearMap.ker` isn't obviously a two-sided ideal. We also move `Module.annihilator` from Ideal/Operations to Ideal/Maps (where `RingHom.ker` is defined).
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Module.annihilator using RingHom.kerModule.annihilator using RingHom.ker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original definition
LinearMap.ker (LinearMap.lsmul R M)doesn't work in the noncommutative setting, becauselsmulisn'tR-linear ifRis noncommutative, and alsoLinearMap.kerisn't obviously a two-sided ideal. We also moveModule.annihilatorfrom Ideal/Operations to Ideal/Maps (whereRingHom.keris defined).