[Merged by Bors] - feat: add uppercase lean 3 linter#1796
Closed
[Merged by Bors] - feat: add uppercase lean 3 linter#1796
Conversation
Contributor
|
I'm going to add some logic to allow the most common Lean 3 name components with capital letters ( |
Member
|
bors merge |
|
✌️ digama0 can now approve this pull request. To approve and merge a pull request, simply reply with |
bors bot
pushed a commit
that referenced
this pull request
Jan 25, 2023
* [ ] depends on: #1794 Implements a linter for lean 3 declarations containing capital letters (as [suggested on Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/non-aligned.20definitions/near/323102645)). Co-authored-by: Mario Carneiro <di.gama@gmail.com>
|
Build failed (retrying...): |
Member
|
as expected, this has merge conflicts bors r- |
|
Canceled. |
Contributor
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jan 26, 2023
* [ ] depends on: #1794 Implements a linter for lean 3 declarations containing capital letters (as [suggested on Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/non-aligned.20definitions/near/323102645)). Co-authored-by: Mario Carneiro <di.gama@gmail.com>
|
Pull request successfully merged into master. Build succeeded:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a linter for lean 3 declarations containing capital letters (as suggested on Zulip).