Skip to content

[Merged by Bors] - chore: Rename OpenEmbedding to IsOpenEmbedding#17898

Closed
YaelDillies wants to merge 2 commits intomasterfrom
rename_open_embedding
Closed

[Merged by Bors] - chore: Rename OpenEmbedding to IsOpenEmbedding#17898
YaelDillies wants to merge 2 commits intomasterfrom
rename_open_embedding

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies commented Oct 18, 2024

Function.Embedding is a type while Embedding is a proposition, and there are many other kinds of embeddings than topological embeddings. Hence this PR is a step towards

  1. renaming Embedding to IsEmbedding and similarly for neighborhing declarations (which OpenEmbedding is)
  2. namespacing it inside Topology

Zulip. See #15993 for context.

Open in Gitpod

@YaelDillies YaelDillies added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-topology Topological spaces, uniform spaces, metric spaces, filters labels Oct 18, 2024
This was referenced Oct 18, 2024
Closed
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 18, 2024 •
edited
Loading

PR summary 55e9d277fe

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ContMDiff.of_comp_isOpenEmbedding
+ IsLocallyInjective_iff_isOpenEmbedding
+ IsOpen.isOpenEmbedding_subtypeVal
+ IsOpenEmbedding
+ IsOpenEmbedding.coborder_preimage
+ IsOpenEmbedding.compatiblePreserving
+ IsOpenEmbedding.continuous
+ IsOpenEmbedding.continuousAt_iff
+ IsOpenEmbedding.functor_isContinuous
+ IsOpenEmbedding.functor_obj_injective
+ IsOpenEmbedding.generalizingMap
+ IsOpenEmbedding.isLocalHomeomorph
+ IsOpenEmbedding.isOpenMap
+ IsOpenEmbedding.isQuasiSeparated_iff
+ IsOpenEmbedding.locPathConnectedSpace
+ IsOpenEmbedding.locallyCompactSpace
+ IsOpenEmbedding.locallyConnectedSpace
+ IsOpenEmbedding.map_nhdsWithin_preimage_eq
+ IsOpenEmbedding.map_nhds_eq
+ IsOpenEmbedding.measurableEmbedding
+ IsOpenEmbedding.open_iff_image_open
+ IsOpenEmbedding.open_iff_preimage_open
+ IsOpenEmbedding.prod
+ IsOpenEmbedding.prodMap
+ IsOpenEmbedding.quasiSober
+ IsOpenEmbedding.restrictPreimage
+ IsOpenEmbedding.singleton_smoothManifoldWithCorners
+ IsOpenEmbedding.tendsto_nhds_iff
+ IsOpenEmbedding.tendsto_nhds_iff'
+ QuasiSeparatedSpace.of_isOpenEmbedding
+ Set.restrictPreimage_isOpenEmbedding
+ Sigma.isOpenEmbedding_ι
+ TopCat.Presheaf.isSheaf_of_isOpenEmbedding
+ _root_.Embedding.toIsOpenEmbedding_of_surjective
+ contMDiffOn_isOpenEmbedding_symm
+ contMDiff_isOpenEmbedding
+ finiteCoproduct.isOpenEmbedding_ι
+ fromGlued_isOpenEmbedding
+ fromOpenSubsetsGlue_isOpenEmbedding
+ fst_isOpenEmbedding_of_right
+ instance (X : LocallyRingedSpace) {U : TopCat} (f : U ⟶ X.toTopCat) (hf : IsOpenEmbedding f) :
+ instance : (topologically IsOpenEmbedding).RespectsIso
+ instance : LocPathConnectedSpace ℍ := isOpenEmbedding_coe.locPathConnectedSpace
+ isLocalHomeomorphOn_iff_isOpenEmbedding_restrict
+ isLocalHomeomorph_iff_isOpenEmbedding_restrict
+ isOpenEmbedding'
+ isOpenEmbedding_exp
+ isOpenEmbedding_id
+ isOpenEmbedding_iff_comp_isIso
+ isOpenEmbedding_iff_comp_isIso'
+ isOpenEmbedding_iff_continuous_injective_open
+ isOpenEmbedding_iff_embedding_open
+ isOpenEmbedding_iff_isIso_comp
+ isOpenEmbedding_iff_isIso_comp'
+ isOpenEmbedding_iff_isOpenEmbedding_of_iSup_eq_top
+ isOpenEmbedding_inl
+ isOpenEmbedding_inr
+ isOpenEmbedding_isLocalAtTarget
+ isOpenEmbedding_mk
+ isOpenEmbedding_mk_symm
+ isOpenEmbedding_natCast
+ isOpenEmbedding_obj_top
+ isOpenEmbedding_of_comp
+ isOpenEmbedding_of_continuous_injective_open
+ isOpenEmbedding_of_embedding_open
+ isOpenEmbedding_of_injective
+ isOpenEmbedding_of_le
+ isOpenEmbedding_of_pullback_open_embeddings
+ isOpenEmbedding_restrict
+ isOpenEmbedding_sigmaMk
+ isOpenEmbedding_sigma_map
+ isOpenEmbedding_val
+ localization_away_isOpenEmbedding
+ pullback_map_isOpenEmbedding
+ separated_by_isOpenEmbedding
+ sigma_ι_isOpenEmbedding
+ snd_isOpenEmbedding_of_left
+ stalkPushforward_iso_of_isOpenEmbedding
+ to_isOpenEmbedding
++ ι_isOpenEmbedding
++++ isOpenEmbedding_coe
+++++ isOpenEmbedding
+++++----- openEmbedding
++++---- openEmbedding_coe
++-- ι_openEmbedding
+-+- restrictTopIso
+-+-+- of_stalk_iso
- OpenEmbedding.prod
- instance (X : LocallyRingedSpace) {U : TopCat} (f : U ⟶ X.toTopCat) (hf : OpenEmbedding f) :
- instance : (topologically OpenEmbedding).RespectsIso
- instance : LocPathConnectedSpace ℍ := openEmbedding_coe.locPathConnectedSpace
- openEmbedding_isLocalAtTarget
- openEmbedding_of_continuous_injective_open
-++- restrict

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Oct 18, 2024
@YaelDillies
chore: Rename OpenEmbedding to IsOpenEmbedding
4798040 
 `Function.Embedding` is a type while `Embedding` is a proposition, and there are many other kinds of embeddings than topological embeddings. Hence this PR is a step towards
1. renaming `Embedding` to `IsEmbedding` and similarly for neighborhing declarations (which `OpenEmbedding` is)
2. namespacing it inside `Topology`

[Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/rename.20.60Inducing.60.20and.20.60Embedding.60.3F). See #15993 for context.
@YaelDillies
deprecated aliases
55e9d27
@urkud
Copy link
Copy Markdown
Member

urkud commented Oct 18, 2024

Please drop the new sh file from this PR (possibly opening a new PR with the file). Otherwise LGTM. Thanks!
bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 18, 2024

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@YaelDillies YaelDillies force-pushed the rename_open_embedding branch from f4a7084 to 55e9d27 Compare October 18, 2024 21:03
@github-actions github-actions bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Oct 18, 2024
@YaelDillies
Copy link
Copy Markdown
Contributor Author

YaelDillies commented Oct 18, 2024

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Oct 18, 2024
@YaelDillies
chore: Rename OpenEmbedding to IsOpenEmbedding (#17898)
de5d061 
`Function.Embedding` is a type while `Embedding` is a proposition, and there are many other kinds of embeddings than topological embeddings. Hence this PR is a step towards
1. renaming `Embedding` to `IsEmbedding` and similarly for neighborhing declarations (which `OpenEmbedding` is)
2. namespacing it inside `Topology`

[Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/rename.20.60Inducing.60.20and.20.60Embedding.60.3F). See #15993 for context.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 18, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: Rename OpenEmbedding to IsOpenEmbedding [Merged by Bors] - chore: Rename OpenEmbedding to IsOpenEmbedding Oct 18, 2024
@mathlib-bors mathlib-bors bot closed this Oct 18, 2024
@mathlib-bors mathlib-bors bot deleted the rename_open_embedding branch October 18, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@YaelDillies @urkud