[Merged by Bors] - refactor(SetTheory/Ordinal/Principal): fix bad names#17842
Closed
[Merged by Bors] - refactor(SetTheory/Ordinal/Principal): fix bad names#17842
Conversation
6 tasks
PR summary 0e8b453d08Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
eric-wieser
approved these changes
Nov 1, 2024
Member
eric-wieser
left a comment
There was a problem hiding this comment.
bors d+
one optional (family of) suggestions
Contributor
|
✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with |
Collaborator
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
This PR performs the following renames: - `principal_add_isLimit` → `isLimit_of_principal_add` - `principal_mul_isLimit` → `isLimit_of_principal_mul` - `opow_principal_add_of_principal_add` → `principal_add_opow_of_principal_add` - `mul_principal_add_is_principal_add` → `principal_add_mul_of_principal_add`
Contributor
|
Pull request successfully merged into master. Build succeeded: |
grunweg
pushed a commit
that referenced
this pull request
Nov 2, 2024
This PR performs the following renames: - `principal_add_isLimit` → `isLimit_of_principal_add` - `principal_mul_isLimit` → `isLimit_of_principal_mul` - `opow_principal_add_of_principal_add` → `principal_add_opow_of_principal_add` - `mul_principal_add_is_principal_add` → `principal_add_mul_of_principal_add`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR performs the following renames:
principal_add_isLimit→isLimit_of_principal_addprincipal_mul_isLimit→isLimit_of_principal_mulopow_principal_add_of_principal_add→principal_add_opow_of_principal_addmul_principal_add_is_principal_add→principal_add_mul_of_principal_add