[Merged by Bors] - chore: do not depend on CategoryTheory in Module.Injective#17747
Closed
eric-wieser wants to merge 6 commits intomasterfrom
Closed
[Merged by Bors] - chore: do not depend on CategoryTheory in Module.Injective#17747eric-wieser wants to merge 6 commits intomasterfrom
eric-wieser wants to merge 6 commits intomasterfrom
Conversation
PR summary 32ccd8f6cd
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Category.ModuleCat.Injective | 1509 | 1065 | -444 (-29.42%) |
| Mathlib.Algebra.Module.Injective | 1064 | 891 | -173 (-16.26%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Algebra.Category.ModuleCat.Injective |
-444 |
Mathlib.Algebra.Module.Injective |
-173 |
17 filesMathlib.RingTheory.Flat.Basic Mathlib.RingTheory.Regular.RegularSequence Mathlib.RingTheory.Unramified.Field Mathlib.RingTheory.Regular.IsSMulRegular Mathlib.Algebra.Category.Grp.EnoughInjectives Mathlib.RingTheory.Etale.Field Mathlib.RingTheory.Flat.Algebra Mathlib.RingTheory.Flat.CategoryTheory Mathlib.LinearAlgebra.LinearDisjoint Mathlib.RingTheory.Flat.FaithfullyFlat Mathlib.RingTheory.AdicCompletion.AsTensorProduct Mathlib.Algebra.Module.CharacterModule Mathlib.RingTheory.Flat.EquationalCriterion Mathlib.RingTheory.LocalRing.Module Mathlib.RingTheory.Flat.Stability Mathlib.Algebra.Category.Grp.Injective Mathlib.RingTheory.Unramified.Finite |
1 |
Mathlib.Algebra.Category.ModuleCat.EnoughInjectives |
1510 |
Declarations diff
+ ModuleCat.ulift_injective_of_injective.{v'}
+ injective_iff_injective_object
+ injective_module_of_injective_object
+ injective_object_of_injective_module
- Module.injective_iff_injective_object
- Module.injective_module_of_injective_object
- Module.injective_object_of_injective_module
- ModuleCat.ulift_injective_of_injective
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
alreadydone
reviewed
Oct 14, 2024
eric-wieser
commented
Oct 16, 2024
Ruben-VandeVelde
approved these changes
Oct 17, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
Looks reasonable
alreadydone
reviewed
Oct 25, 2024
alreadydone
approved these changes
Oct 26, 2024
Contributor
alreadydone
left a comment
There was a problem hiding this comment.
Thanks!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by alreadydone. |
Contributor
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 26, 2024
The category-theoretic results can be split between `Mathlib/Algebra/Category/Grp/Injective.lean` and `Mathlib/Algebra/Category/ModuleCat/Injective.lean` instead, with no changes to downstream proofs. Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The category-theoretic results can be split between
Mathlib/Algebra/Category/Grp/Injective.leanandMathlib/Algebra/Category/ModuleCat/Injective.leaninstead, with no changes to downstream proofs.