[Merged by Bors] - chore(*): replace erw with rw where possible#17703
Closed
Vierkantor wants to merge 5 commits intomasterfrom
Closed
[Merged by Bors] - chore(*): replace erw with rw where possible#17703Vierkantor wants to merge 5 commits intomasterfrom
erw with rw where possible#17703Vierkantor wants to merge 5 commits intomasterfrom
Conversation
2 tasks
PR summary 13ba5856b7Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
grunweg
reviewed
Oct 13, 2024
Contributor
grunweg
left a comment
There was a problem hiding this comment.
Thanks!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
Contributor
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 13, 2024
Go through Mathlib and replace `erw` calls where `rw` would also succeed. This PR is split off from #17638, containing all the changes that the linter suggested. Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
erw with rw where possibleerw with rw where possible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go through Mathlib and replace
erwcalls whererwwould also succeed.This PR is split off from #17638, containing all the changes that the linter suggested.