[Merged by Bors] - chore: clean up after #17615#17617
Closed
Vierkantor wants to merge 6 commits intomasterfrom
Closed
[Merged by Bors] - chore: clean up after #17615#17617Vierkantor wants to merge 6 commits intomasterfrom
Vierkantor wants to merge 6 commits intomasterfrom
Conversation
PR summary 718b578fa0Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
Collaborator
|
This PR/issue depends on: |
This PR goes through the diff of #17615, which automatically replaced `erw` with `rw`) to clean up as follows: * delete obsolote comments * merge adjacent `rw` calls * restore old code that broke at some point but now works again
03e52a1 to
9dfed9f
Compare
grunweg
approved these changes
Oct 10, 2024
Contributor
grunweg
left a comment
There was a problem hiding this comment.
Looks great, thanks for doing this! I just have three minor comments.
Vierkantor
commented
Oct 10, 2024
Contributor
|
Thanks! |
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
Contributor
|
Thanks! |
Contributor
Author
|
(I assume you mean |
2 tasks
Contributor
Author
|
I'm going to go ahead and assume that was meant as a: bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 11, 2024
This PR goes through the diff of #17615, which automatically replaced `erw` with `rw`, to clean up as follows: * delete obsolote comments * merge adjacent `rw` calls * restore old code that was commented out when it broke at some point but now works again Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Contributor
|
Ah whoops! Yes, somehow I managed to drop the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR goes through the diff of #17615, which automatically replaced
erwwithrw, to clean up as follows:rwcallserwwithrwthat work as well #17615