Skip to content

[Merged by Bors] - feat(CategoryTheory/Limits): generalize universes in Preserves.Filtered and add Reflects classes#17537

Closed
dagurtomas wants to merge 3 commits intomasterfrom
dagur/FilteredUniv
Closed

[Merged by Bors] - feat(CategoryTheory/Limits): generalize universes in Preserves.Filtered and add Reflects classes#17537
dagurtomas wants to merge 3 commits intomasterfrom
dagur/FilteredUniv

Conversation

@dagurtomas
Copy link
Copy Markdown
Contributor

@dagurtomas dagurtomas commented Oct 8, 2024

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 8, 2024 •
edited
Loading

PR summary 20da374a07

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ PreservesCofilteredLimitsOfSize
+ PreservesFilteredColimitsOfSize
+ ReflectsCofilteredLimits
+ ReflectsCofilteredLimitsOfSize
+ ReflectsFilteredColimits
+ ReflectsFilteredColimitsOfSize
+ compReflectsCofilteredLimits
+ compReflectsFilteredColimits
+ instance (priority := 100) ReflectsColimits.reflectsFilteredColimits (F : C ⥤ D)
+ instance (priority := 100) ReflectsLimits.reflectsCofilteredLimits (F : C ⥤ D)
+ preservesCofilteredLimitsOfSizeOfUnivLE
+ preservesCofilteredLimitsOfSizeShrink
+ preservesFilteredColimitsOfSizeOfUnivLE
+ preservesFilteredColimitsOfSizeShrink
+ preservesSmallestCofilteredLimitsOfPreservesCofilteredLimits
+ preservesSmallestFilteredColimitsOfPreservesFilteredColimits
+ reflectsCofilteredLimitsOfSizeOfUnivLE
+ reflectsCofilteredLimitsOfSizeShrink
+ reflectsFilteredColimitsOfSizeOfUnivLE
+ reflectsFilteredColimitsOfSizeShrink
+ reflectsSmallestCofilteredLimitsOfReflectsCofilteredLimits
+ reflectsSmallestFilteredColimitsOfReflectsFilteredColimits

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@github-actions github-actions bot added the t-category-theory Category theory label Oct 8, 2024
@dagurtomas dagurtomas mentioned this pull request Oct 8, 2024
Closed
11 tasks
joelriou
joelriou reviewed Oct 9, 2024
View reviewed changes
joelriou
joelriou reviewed Oct 9, 2024
View reviewed changes
@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 9, 2024
@dagurtomas dagurtomas removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 10, 2024
joelriou
joelriou reviewed Oct 11, 2024
View reviewed changes
@erdOne erdOne added the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 11, 2024
@dagurtomas dagurtomas removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 11, 2024
jcommelin
jcommelin reviewed Oct 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Oct 17, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 17, 2024
@dagurtomas
feat(CategoryTheory/Limits): generalize universes in `Preserves.Filte…
fff90ff 
…red` and add `Reflects` classes (#17537)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 17, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory/Limits): generalize universes in Preserves.Filtered and add Reflects classes [Merged by Bors] - feat(CategoryTheory/Limits): generalize universes in Preserves.Filtered and add Reflects classes Oct 17, 2024
@mathlib-bors mathlib-bors bot closed this Oct 17, 2024
@mathlib-bors mathlib-bors bot deleted the dagur/FilteredUniv branch October 17, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcommelin jcommelin jcommelin left review comments

@joelriou joelriou joelriou left review comments

Assignees

No one assigned

Labels

ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dagurtomas @jcommelin @joelriou @erdOne