Skip to content

[Merged by Bors] - chore: weaken typeclass assumptions MetricSpacePseudoMetricSpace#17520

Closed
grunweg wants to merge 4 commits intomasterfrom
MR-met-weaken
Closed

[Merged by Bors] - chore: weaken typeclass assumptions MetricSpacePseudoMetricSpace#17520
grunweg wants to merge 4 commits intomasterfrom
MR-met-weaken

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Oct 7, 2024

Discovered through the linter in #17519 (but in fact not related to it).


Open in Gitpod

@grunweg grunweg added easy < 20s of review time. See the lifecycle page for guidelines. t-topology Topological spaces, uniform spaces, metric spaces, filters and removed easy < 20s of review time. See the lifecycle page for guidelines. labels Oct 7, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 7, 2024

PR summary a077c04bd1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@github-actions github-actions bot added the t-measure-probability Measure theory / Probability theory label Oct 7, 2024
@eric-wieser
Copy link
Copy Markdown
Member

!bench

@eric-wieser
Copy link
Copy Markdown
Member

This generalization can go quite a lot further... Let me try pushing some more.

@eric-wieser
Copy link
Copy Markdown
Member

I span off #17526 rather than getting carried away beyond MeasureTheory.

@eric-wieser eric-wieser changed the title chore: weaken typeclass assumptions MetricSpace -> PseudoMetricSpace chore: weaken typeclass assumptions MetricSpacePseudoMetricSpace Oct 7, 2024
@leanprover-bot
Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit bf6acc2.
The entire run failed.
Found no significant differences.

@eric-wieser
Copy link
Copy Markdown
Member

!bench

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit ffdeea1.
The entire run failed.
Found no significant differences.

@RemyDegenne
Copy link
Copy Markdown
Contributor

It looks good and I think we could merge. Do you still want to try and get a working benchmark?

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Oct 13, 2024

!bench

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Oct 13, 2024

The speed-center is back up, so let's hopefully just wait a short moment until the benchmarking results are in. If this doesn't work, I'm happy to merge it as-is.

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit cb4f038.
The entire run failed.
Found no significant differences.

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Oct 13, 2024

Once more with feeling: need to benchmark again after merging master.

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Oct 13, 2024

!bench

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit a077c04.
There were no significant changes against commit 1e919af.

@RemyDegenne
Copy link
Copy Markdown
Contributor

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 14, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 14, 2024
…e` (#17520)

Discovered through the linter in #17519 (but in fact not related to it).



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 14, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: weaken typeclass assumptions MetricSpacePseudoMetricSpace [Merged by Bors] - chore: weaken typeclass assumptions MetricSpacePseudoMetricSpace Oct 14, 2024
@mathlib-bors mathlib-bors bot closed this Oct 14, 2024
@mathlib-bors mathlib-bors bot deleted the MR-met-weaken branch October 14, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-measure-probability Measure theory / Probability theory t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants