[Merged by Bors] - chore: weaken typeclass assumptions MetricSpace → PseudoMetricSpace#17520
[Merged by Bors] - chore: weaken typeclass assumptions MetricSpace → PseudoMetricSpace#17520
MetricSpace → PseudoMetricSpace#17520Conversation
PR summary a077c04bd1Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
|
!bench |
|
This generalization can go quite a lot further... Let me try pushing some more. |
|
I span off #17526 rather than getting carried away beyond MeasureTheory. |
MetricSpace -> PseudoMetricSpaceMetricSpace → PseudoMetricSpace
|
Here are the benchmark results for commit bf6acc2. |
|
!bench |
|
Here are the benchmark results for commit ffdeea1. |
|
It looks good and I think we could merge. Do you still want to try and get a working benchmark? |
|
!bench |
|
The speed-center is back up, so let's hopefully just wait a short moment until the benchmarking results are in. If this doesn't work, I'm happy to merge it as-is. |
|
Here are the benchmark results for commit cb4f038. |
|
Once more with feeling: need to benchmark again after merging master. |
|
!bench |
|
Here are the benchmark results for commit a077c04. |
|
bors r+ |
|
Pull request successfully merged into master. Build succeeded: |
MetricSpace → PseudoMetricSpaceMetricSpace → PseudoMetricSpace
Discovered through the linter in #17519 (but in fact not related to it).