Skip to content

[Merged by Bors] - feat: port Algebra.IndicatorFunction#1752

Closed
LukasMias wants to merge 12 commits intomasterfrom
port/Algebra.IndicatorFunction
Closed

[Merged by Bors] - feat: port Algebra.IndicatorFunction#1752
LukasMias wants to merge 12 commits intomasterfrom
port/Algebra.IndicatorFunction

Conversation

@LukasMias
Copy link
Copy Markdown
Contributor

@LukasMias LukasMias commented Jan 21, 2023

Some mathport warning to pay attention to, and some proofs required some work explicitly using split_ifs which was not necessary in lean3, but otherwise straightforward.


Open in Gitpod

Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@LukasMias LukasMias added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 21, 2023
@LukasMias LukasMias added the help-wanted The author needs attention to resolve issues label Jan 21, 2023
@LukasMias LukasMias added awaiting-review and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Jan 22, 2023
@ChrisHughes24
Copy link
Copy Markdown
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jan 22, 2023
@bors
Copy link
Copy Markdown

bors bot commented Jan 22, 2023

Canceled.

bors bot pushed a commit that referenced this pull request Jan 22, 2023
Some mathport warning to pay attention to, and some proofs required some work explicitly using `split_ifs` which was not necessary in lean3, but otherwise straightforward.



Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
@ChrisHughes24
Copy link
Copy Markdown
Member

bors merge

bors bot pushed a commit that referenced this pull request Jan 22, 2023
Some mathport warning to pay attention to, and some proofs required some work explicitly using `split_ifs` which was not necessary in lean3, but otherwise straightforward.



Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Jan 22, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.IndicatorFunction [Merged by Bors] - feat: port Algebra.IndicatorFunction Jan 22, 2023
@bors bors bot closed this Jan 22, 2023
@bors bors bot deleted the port/Algebra.IndicatorFunction branch January 22, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants