Skip to content

[Merged by Bors] - chore(Algebra/Module/Equiv/Defs): remove FunLike instance#17477

Closed
mo271 wants to merge 1 commit intomasterfrom
mo271/rm_FunLike
Closed

[Merged by Bors] - chore(Algebra/Module/Equiv/Defs): remove FunLike instance#17477
mo271 wants to merge 1 commit intomasterfrom
mo271/rm_FunLike

Conversation

@mo271
Copy link
Copy Markdown
Collaborator

@mo271 mo271 commented Oct 6, 2024


Open in Gitpod

@mo271
Copy link
Copy Markdown
Collaborator Author

mo271 commented Oct 6, 2024

!bench

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 6, 2024

PR summary 0a0c535bcd

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

- instance : FunLike (M ≃ₛₗ[σ] M₂) M M₂

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Oct 6, 2024
@leanprover-bot
Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit 4cc4221.
The entire run failed.
Found no significant differences.

@mo271
Copy link
Copy Markdown
Collaborator Author

mo271 commented Oct 6, 2024

!bench

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit 4cc4221.
The entire run failed.
Found no significant differences.

@mo271
Copy link
Copy Markdown
Collaborator Author

mo271 commented Oct 8, 2024

!bench

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit 4cc4221.
The entire run failed.
Found no significant differences.

@mo271
Copy link
Copy Markdown
Collaborator Author

mo271 commented Oct 10, 2024

!bench

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit 4cc4221.
The entire run failed.
Found no significant differences.

@mo271
Copy link
Copy Markdown
Collaborator Author

mo271 commented Oct 17, 2024

!bench

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit 4cc4221.
The entire run failed.
Found no significant differences.

@mo271
Copy link
Copy Markdown
Collaborator Author

mo271 commented Oct 17, 2024

!bench

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit 0a0c535.
There were significant changes against commit 12a1544:

  Benchmark                            Metric         Change
  ==========================================================
+ ~Mathlib.LinearAlgebra.TensorPower   instructions   -14.1%

@mo271
Copy link
Copy Markdown
Collaborator Author

mo271 commented Oct 17, 2024

Not sure how/if this interacts with #17870, but this one here is ready for review.

Copy link
Copy Markdown
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the benchmark is so positive, but I'll take it.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 18, 2024

✌️ mo271 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Oct 18, 2024
@Vierkantor
Copy link
Copy Markdown
Contributor

(It's still marked as a draft so I can't merge it.)

@mo271 mo271 marked this pull request as ready for review October 18, 2024 08:08
@mo271
Copy link
Copy Markdown
Collaborator Author

mo271 commented Oct 18, 2024

oops, marked as ready for review now...

@mo271
Copy link
Copy Markdown
Collaborator Author

mo271 commented Oct 18, 2024

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Oct 18, 2024
Co-authored-by: Moritz Firsching <firsching@google.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 18, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Algebra/Module/Equiv/Defs): remove FunLike instance [Merged by Bors] - chore(Algebra/Module/Equiv/Defs): remove FunLike instance Oct 18, 2024
@mathlib-bors mathlib-bors bot closed this Oct 18, 2024
@mathlib-bors mathlib-bors bot deleted the mo271/rm_FunLike branch October 18, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants