Skip to content

[Merged by Bors] - feat: Noetherian/Artinian is closed under extensions (submodule form)#17425

Closed
alreadydone wants to merge 1 commit intomasterfrom
noether-artin-extension
Closed

[Merged by Bors] - feat: Noetherian/Artinian is closed under extensions (submodule form)#17425
alreadydone wants to merge 1 commit intomasterfrom
noether-artin-extension

Conversation

@alreadydone
Copy link
Copy Markdown
Contributor

@alreadydone alreadydone commented Oct 4, 2024


In preparation of proving finite length = Noetherian + Artinian. The proof here unnecessarily uses Jordan--Hoelder.

Open in Gitpod

@alreadydone alreadydone added the t-algebra Algebra (groups, rings, fields, etc) label Oct 4, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 4, 2024

PR summary 4e1c59480a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance (priority := 80) _root_.isNoetherian_of_finite [Finite M] : IsNoetherian R M
+ isArtinian_iff_submodule_quotient
+ isNoetherian_iff_submodule_quotient
- instance (priority := 80) isNoetherian_of_finite (R M) [Finite M] [Semiring R] [AddCommMonoid M]

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@alreadydone alreadydone changed the title feat: Noetherian/Artinian is closed under extensions feat: Noetherian/Artinian is closed under extensions (submodule form) Oct 4, 2024
@alreadydone alreadydone added the easy < 20s of review time. See the lifecycle page for guidelines. label Oct 4, 2024
@Ruben-VandeVelde Ruben-VandeVelde removed the easy < 20s of review time. See the lifecycle page for guidelines. label Oct 5, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 7, 2024
In the proof of `wellFounded_lt_exact_sequence`, it is implicitly shown that `fun x : α ↦ (x ⊓ z, x ⊔ z)` is StrictMono in a modular lattice, with the lexicographic order on `α × α`. Here we show the stronger result with `α × α` equipped with the product order, and golf the proof.

If `G` is not an abelian group, then `α = Subgroup G` is not necessarily a modular lattice. However, if `z` is a normal subgroup, the result still holds true. We prove a closely related result `strictMono_comap_prod_map` which replaces `inf` with `comap` and `sup` with `map`, so it concerns a function to `Subgroup z × Subgroup (G ⧸ z)` instead. The same result for submodules immediately implies that Noetherian/Artinian are closed under extensions, which is proven in #17425 using `wellFounded_lt/gt_exact_sequence`.

If `z` is not even normal, the function to `Subgroup z × Set (G ⧸ z)` is still StrictMono.
@erdOne
Copy link
Copy Markdown
Member

erdOne commented Oct 7, 2024

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 7, 2024

🚀 Pull request has been placed on the maintainer queue by erdOne.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Oct 7, 2024
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Oct 7, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 7, 2024
…#17425)

+ Add `isNoetherian/Artinian_iff_submodule_quotient`.

+ Remove unnecessary assumptions from `isArtinian_of_range_eq_ker`, mimicking #12453.

+ Move up two instances `isArtinian_of_quotient_of_artinian` and `isNoetherian_of_finite`.

+ Golf `isNoetherian/Artinian_pi`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 7, 2024

This PR was included in a batch that was canceled, it will be automatically retried

mathlib-bors bot pushed a commit that referenced this pull request Oct 7, 2024
…#17425)

+ Add `isNoetherian/Artinian_iff_submodule_quotient`.

+ Remove unnecessary assumptions from `isArtinian_of_range_eq_ker`, mimicking #12453.

+ Move up two instances `isArtinian_of_quotient_of_artinian` and `isNoetherian_of_finite`.

+ Golf `isNoetherian/Artinian_pi`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 7, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Noetherian/Artinian is closed under extensions (submodule form) [Merged by Bors] - feat: Noetherian/Artinian is closed under extensions (submodule form) Oct 7, 2024
@mathlib-bors mathlib-bors bot closed this Oct 7, 2024
@mathlib-bors mathlib-bors bot deleted the noether-artin-extension branch October 7, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants