[Merged by Bors] - chore(Analysis/InnerProductSpace/Dual): weaken assumptions to SeminormedAddCommGroup#17416
Closed
yoh-tanimoto wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - chore(Analysis/InnerProductSpace/Dual): weaken assumptions to SeminormedAddCommGroup#17416yoh-tanimoto wants to merge 3 commits intomasterfrom
yoh-tanimoto wants to merge 3 commits intomasterfrom
Conversation
3 tasks
PR summary e252985f4bImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
eric-wieser
reviewed
Oct 4, 2024
|
|
||
| variable (𝕜 : Type*) | ||
| variable (E : Type*) [RCLike 𝕜] [NormedAddCommGroup E] [InnerProductSpace 𝕜 E] | ||
| variable (E : Type*) [RCLike 𝕜] [SeminormedAddCommGroup E] [InnerProductSpace 𝕜 E] |
Member
There was a problem hiding this comment.
Can you move
variable (𝕜 : Type*) (E : Type*)
outside the section so that you don't need to repeat it?
Collaborator
Author
There was a problem hiding this comment.
done. Is it ok to have [RCLike 𝕜] inside section?
eric-wieser
approved these changes
Oct 4, 2024
Member
|
bors merge Thanks! |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the
NormedAddCommGroupassumption withSemiNormedAddCommGroupwhere possible.motivation: we need
toDual,toDualMapetc. to define anInnerProductSpaceinstance forSeparationQuotient.suggested in #16707.