Skip to content

[Merged by Bors] - chore(Profinite): add Fintype instances#17380

Closed
dagurtomas wants to merge 1 commit intomasterfrom
dagur/ProfiniteInstances
Closed

[Merged by Bors] - chore(Profinite): add Fintype instances#17380
dagurtomas wants to merge 1 commit intomasterfrom
dagur/ProfiniteInstances

Conversation

@dagurtomas
Copy link
Copy Markdown
Contributor

@dagurtomas dagurtomas commented Oct 3, 2024

This is useful in #14027

Open in Gitpod

@dagurtomas dagurtomas added the easy < 20s of review time. See the lifecycle page for guidelines. label Oct 3, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 3, 2024

PR summary 9f503a9c08

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance (X : FintypeCat) : Fintype (FintypeCat.toProfinite.obj X) := inferInstanceAs (Fintype X)
+ instance (X : FintypeCat) : Fintype (Profinite.of X) := inferInstanceAs (Fintype X)
+ instance (X : FintypeCat.{u}) : Fintype (FintypeCat.toLightProfinite.obj X)
+ instance (X : FintypeCat.{u}) : Fintype (LightProfinite.of X) := inferInstanceAs (Fintype X)

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Oct 3, 2024
@dagurtomas dagurtomas mentioned this pull request Oct 4, 2024
Closed
6 tasks
jcommelin
jcommelin reviewed Oct 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Oct 4, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 4, 2024
@dagurtomas
chore(Profinite): add Fintype instances (#17380)
5c8459b
mathlib-bors bot pushed a commit that referenced this pull request Oct 4, 2024
@dagurtomas
chore(Profinite): add Fintype instances (#17380)
2dcb3ba
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 4, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Profinite): add Fintype instances [Merged by Bors] - chore(Profinite): add Fintype instances Oct 4, 2024
@mathlib-bors mathlib-bors bot closed this Oct 4, 2024
@mathlib-bors mathlib-bors bot deleted the dagur/ProfiniteInstances branch October 4, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees

No one assigned

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dagurtomas @jcommelin