[Merged by Bors] - fix: make List.rec and Nat.rec computable#1720
Closed
eric-wieser wants to merge 9 commits intomasterfrom
Closed
[Merged by Bors] - fix: make List.rec and Nat.rec computable#1720eric-wieser wants to merge 9 commits intomasterfrom
eric-wieser wants to merge 9 commits intomasterfrom
Conversation
sgouezel
reviewed
Jan 20, 2023
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
eric-wieser
commented
Jan 20, 2023
bors bot
pushed a commit
that referenced
this pull request
Jan 20, 2023
This works around leanprover/lean4#2049. By manually adding compiler support for these recursors, we make a large number of porting notes redundant.
|
Pull request successfully merged into master. Build succeeded:
|
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 19, 2023
#1720 made `List.rec` computable and therefore made it possible to restore the simpler versions of `foldrRecOn` and `foldlRecOn`.
alexkeizer
pushed a commit
that referenced
this pull request
Nov 21, 2023
#1720 made `List.rec` computable and therefore made it possible to restore the simpler versions of `foldrRecOn` and `foldlRecOn`.
grunweg
pushed a commit
that referenced
this pull request
Dec 15, 2023
#1720 made `List.rec` computable and therefore made it possible to restore the simpler versions of `foldrRecOn` and `foldlRecOn`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works around leanprover/lean4#2049. By manually adding compiler support for these recursors, we make a large number of porting notes redundant.