[Merged by Bors] - chore: generalize IsBoundedBilinearMap to seminormed spaces#17011
Closed
eric-wieser wants to merge 7 commits intomasterfrom
Closed
[Merged by Bors] - chore: generalize IsBoundedBilinearMap to seminormed spaces#17011eric-wieser wants to merge 7 commits intomasterfrom
IsBoundedBilinearMap to seminormed spaces#17011eric-wieser wants to merge 7 commits intomasterfrom
Conversation
PR summary 3d3cf51231Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
eric-wieser
commented
Sep 22, 2024
| ‖c x • f‖ = ‖c x‖ * ‖f‖ := norm_smul _ _ | ||
| _ ≤ ‖c‖ * ‖x‖ * ‖f‖ := mul_le_mul_of_nonneg_right (le_opNorm _ _) (norm_nonneg _) | ||
| _ = ‖c‖ * ‖f‖ * ‖x‖ := by ring | ||
| · obtain hf | hf := (norm_nonneg f).eq_or_gt |
Member
Author
There was a problem hiding this comment.
This line of the proof changed
YaelDillies
approved these changes
Sep 23, 2024
Contributor
YaelDillies
left a comment
There was a problem hiding this comment.
Sad to see elaboration issues crop up, but glad that this is generalisable.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Member
|
Thanks 🎉 bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
The claim in `Mathlib/Analysis/NormedSpace/OperatorNorm/NormedSpace.lean` that > This file contains statements about operator norm for which it really matters that the > underlying space has a norm (rather than just a seminorm). was not entirely true. The main trick is to case on whether the norm of an element is zero, rather than on that element itself being zero. Unfortunately this causes some minor elaboration issues downstream, but they are easy to work around.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
IsBoundedBilinearMap to seminormed spacesIsBoundedBilinearMap to seminormed spaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The claim in
Mathlib/Analysis/NormedSpace/OperatorNorm/NormedSpace.leanthatwas not entirely true.
The main trick is to case on whether the norm of an element is zero, rather than on that element itself being zero.
Unfortunately this causes some minor elaboration issues downstream, but they are easy to work around.