[Merged by Bors] - chore: split Algebra.Bounds and Algebra.Order.Pointwise#16986
Closed
YaelDillies wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - chore: split Algebra.Bounds and Algebra.Order.Pointwise#16986YaelDillies wants to merge 4 commits intomasterfrom
YaelDillies wants to merge 4 commits intomasterfrom
Conversation
Move the lemmas about pointwise operations to `Algebra.Order.Group.Pointwise` and the lemmas about complete lattices to `Algebra.Order.Group.CompleteLattice`
PR summary 3fc8540e75
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Bounds | 374 | 0 | -374 (-100.00%) |
| Mathlib.Algebra.Order.Pointwise | 395 | 0 | -395 (-100.00%) |
| Mathlib.Algebra.Order.CompleteField | 1384 | 1383 | -1 (-0.07%) |
| Mathlib.MeasureTheory.Constructions.HaarToSphere | 1860 | 1859 | -1 (-0.05%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Algebra.Order.Pointwise |
-395 |
Mathlib.Algebra.Bounds |
-374 |
14 filesMathlib.NumberTheory.Cyclotomic.Rat Mathlib.NumberTheory.Cyclotomic.Discriminant Mathlib.NumberTheory.NumberField.Discriminant Mathlib.MeasureTheory.Measure.Lebesgue.VolumeOfBalls Mathlib.NumberTheory.Cyclotomic.Three Mathlib.NumberTheory.NumberField.CanonicalEmbedding.FundamentalCone Mathlib.NumberTheory.FLT.Three Mathlib.NumberTheory.NumberField.CanonicalEmbedding.ConvexBody Mathlib.NumberTheory.Cyclotomic.PID Mathlib.NumberTheory.NumberField.Units.DirichletTheorem Mathlib.NumberTheory.NumberField.Units.Regulator Mathlib.MeasureTheory.Constructions.HaarToSphere Mathlib.Algebra.Order.CompleteField Mathlib.NumberTheory.NumberField.ClassNumber |
-1 |
Mathlib.Algebra.Order.Group.CompleteLattice |
369 |
Mathlib.Algebra.Order.Group.Pointwise.Bounds |
373 |
Mathlib.Algebra.Order.Group.Pointwise.CompleteLattice |
375 |
Mathlib.Algebra.Order.Field.Pointwise |
493 |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
It seems like this PR grew bigger than the PR title/summary suggest. Please update them
Comment on lines
+12
to
+13
| In this file we prove a few facts like “`-s` is bounded above iff `s` is bounded below” | ||
| (`bddAbove_neg`). |
Contributor
There was a problem hiding this comment.
This seems to be about another file
Ruben-VandeVelde
approved these changes
Sep 25, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
Delete `Algebra.Bounds` and `Algebra.Order.Pointwise`. Create * `Algebra.Order.Field.Pointwise` for lemmas about pointwise operations in linear ordered fields * `Algebra.Order.Group.CompleteLattice` for distributivity of group operations over supremum/infimum * `Algebra.Order.Group.Pointwise.Bounds` for boundedness of pointwise-defined sets * `Algebra.Order.Group.Pointwise.CompleteLattice` for lemmas about the supremum/infimum of pointwise-defined sets.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
fbarroero
pushed a commit
that referenced
this pull request
Oct 2, 2024
Delete `Algebra.Bounds` and `Algebra.Order.Pointwise`. Create * `Algebra.Order.Field.Pointwise` for lemmas about pointwise operations in linear ordered fields * `Algebra.Order.Group.CompleteLattice` for distributivity of group operations over supremum/infimum * `Algebra.Order.Group.Pointwise.Bounds` for boundedness of pointwise-defined sets * `Algebra.Order.Group.Pointwise.CompleteLattice` for lemmas about the supremum/infimum of pointwise-defined sets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete
Algebra.BoundsandAlgebra.Order.Pointwise. CreateAlgebra.Order.Field.Pointwisefor lemmas about pointwise operations in linear ordered fieldsAlgebra.Order.Group.CompleteLatticefor distributivity of group operations over supremum/infimumAlgebra.Order.Group.Pointwise.Boundsfor boundedness of pointwise-defined setsAlgebra.Order.Group.Pointwise.CompleteLatticefor lemmas about the supremum/infimum of pointwise-defined sets.