Skip to content

[Merged by Bors] - feat(Algebra/Group/Action): add definition of equidecomposition#16936

Closed
Felix-Weilacher wants to merge 35 commits intomasterfrom
equidecomp3
Closed

[Merged by Bors] - feat(Algebra/Group/Action): add definition of equidecomposition#16936
Felix-Weilacher wants to merge 35 commits intomasterfrom
equidecomp3

Conversation

@Felix-Weilacher
Copy link
Copy Markdown
Collaborator

@Felix-Weilacher Felix-Weilacher commented Sep 19, 2024

Define equidecomposition and provide some basic theory and operations.

Zulip


TODO:

Prove that if two sets embeddidecompose into eachother, they are equidecomposable (Schroeder-Bernstein type theorem)
Define embeddidecomposability as a Preorder on sets and prove that its induced equivalence relation is equidecomposability.
Prove the definition of equidecomposition used here is equivalent to the more familiar one using partitions. This equivalence is trivial mathematically, but partitions do not seem well-developed to me in mathlib.

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 19, 2024

PR summary 7f9fa08241

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Algebra.Group.Action.Equidecomp (new file) 698

Declarations diff

+ IsDecompOn
+ IsDecompOn.comp
+ IsDecompOn.comp'
+ IsDecompOn.mono
+ IsDecompOn.of_leftInvOn
+ _root_.Equidecomp
+ apply_mem_target
+ instance : CoeFun (Equidecomp X G) fun _ => X → X := ⟨fun f => f.toFun⟩
+ isDecompOn
+ left_inv
+ map_target
+ refl
+ refl_symm
+ restr
+ restr_of_source_subset
+ restr_refl_symm
+ restr_univ
+ right_inv
+ source_restr
+ source_restr_subset_source
+ symm
+ symm_symm
+ toPartialEquiv_injective
+ toPartialEquiv_restr
+ trans
+ witness

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (1.00, 0.01)
Current number Change Type
107 1 bare open (scoped) Classical

Current commit 7f9fa08241
Reference commit 165731857a

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Felix-Weilacher and others added 6 commits September 19, 2024 12:30
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@joneugster joneugster added the t-algebra Algebra (groups, rings, fields, etc) label Sep 23, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 24, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 19, 2025
@Felix-Weilacher
Copy link
Copy Markdown
Collaborator Author

Thanks for taking a look and fixing the merge conflict!

Co-authored-by: Tristan F.-R. <tristanf@reed.edu>
Copy link
Copy Markdown
Collaborator

@tristan-f-r tristan-f-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the secondary review - just noticed this after a second read.

Felix-Weilacher and others added 2 commits January 27, 2025 17:02
Co-authored-by: Tristan F.-R. <tristanf@reed.edu>
Co-authored-by: Tristan F.-R. <tristanf@reed.edu>
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 29, 2025
@Felix-Weilacher Felix-Weilacher added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Jan 30, 2025
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jan 30, 2025
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jan 30, 2025
@jcommelin
Copy link
Copy Markdown
Member

Thanks 🎉

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jan 31, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 31, 2025
Define equidecomposition and provide some basic theory and operations.

[Zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Banach.20Tarski.20Paradox.20in.20Lean)



Co-authored-by: Felix-Weilacher <fweilach@andrew.cmu.edu>
Co-authored-by: Tristan F. <LeoDog896@hotmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 31, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Group/Action): add definition of equidecomposition [Merged by Bors] - feat(Algebra/Group/Action): add definition of equidecomposition Jan 31, 2025
@mathlib-bors mathlib-bors bot closed this Jan 31, 2025
@mathlib-bors mathlib-bors bot deleted the equidecomp3 branch January 31, 2025 07:36
Julian added a commit that referenced this pull request Feb 2, 2025
* factorial-dvd-int: (143 commits)
  Apply suggestions from code review
  feat(Factorial): k! divides the product of any k successive integers
  feat(CategoryTheory): creation of finite limits (#21320)
  chore: update Mathlib dependencies 2025-02-01 (#21328)
  chore(GroupTheory/SpecificGroups/Alternating.lean): follow last minute review of JX (#21314)
  feat: `‖x‖ₑ.toNNReal = ‖x‖₊` (#21306)
  chore: cleanup imports in Archive/IfNormalization (#21318)
  doc: fix several typos (#21315)
  feat(CategoryTheory): transfer being iso along an iso in the arrow category (#21310)
  chore: delete declarations deprecated between 2024-01 and 2024-07 (#21271)
  feat(Analysis/Normed/Module/Dual): polar in a normed space as a submodule (#20084)
  chore(Data/ZMod/Basic): split `ZMod.valMinAbs` off (#21308)
  feat(GroupTheory/Perm/Centralizer): study the centralizer of a permutation (#17522)
  feat(RingTheory/LocalRing): `IsLocalRing` for subrings (#21168)
  chore: update Mathlib dependencies 2025-02-01 (#21312)
  chore: update Mathlib dependencies 2025-01-31 (#21311)
  feat: generalize `mem_dite` to `Membership α β` (#21262)
  feat: Lemmas for some monomial orders (#16177)
  feat(CategoryTheory): the localized category is monoidal (#12728)
  feat: add function log⁺ (=positive part of the logarithm) and prove standard estimates (#21289)
  feat(RingTheory/WittVector): ring of Witt vectors is p-adically complete (#21295)
  feat(GroupTheory/GroupAction/Blocks): more on blocks (#21284)
  fix(FieldTheory/KrullTopology): make `krullTopology_discreteTopology_of_finiteDimensional` universe polymorphic (#21299)
  feat(RingTheory/Artinian): integral non-zero-divisors are units over artinian rings (#21199)
  refactor(Topology/Gluing): simplify definition of `TopCat.GlueData.Rel` (#20653)
  feat(RingTheory/PowerSeries): binomial series (#20192)
  chore(Mathlib/RingTheory/MvPolynomial): rename MonomiaOrder.lCoeff to MonomialOrder.leadingCoeff  (#21290)
  chore (RingTheory/HahnSeries): fix names that use coeff (#21279)
  feat: let `notation3` distinguish `Prop` vs `Type _ ` vs `Sort _` (#21233)
  chore(MeasureTheory/Function/StronglyMeasurable): split Basic into Basic and AEStronglyMeasurable (#21273)
  feat(CategoryTheory): the monoidal category structure on a localization (#20951)
  feat(Analysis/Complex/Hadamard): generalize Hadamard's three lines theorem (#15009)
  feat(Order/CompleteBooleanAlgebra): Himp in terms of sSup (#20328)
  feat(ENNReal/Basic): add `ofNat_ne_top` and `top_ne_ofNat` (#14486)
  feat: Function.const as a PartialEquiv (#21137)
  chore(NonZeroDivisors): don't import rings (#20871)
  feat(Data/Set/Lattice): insert distributivity with iUnion/iInter (#21267)
  feat(GroupTheory/SpecificGroups/AlternatingGroup): subgroups of index 2 of Equiv.Perm (#21190)
  feat(GroupTheory/GroupAction/Transitive): basic results on transitive actions (#21285)
  perf(MeasureTheory/Function/LpSpace.lean): speed up (#21179)
  feat(Order): order isomorphisms from `Fin n` for small `n` (#21120)
  refactor(Topology/Group): turn morphisms in ProfiniteGrp into one field structures (#20740)
  feat: Sylow's first theorem for elementary `p`-groups (#21072)
  chore(Submonoid/Membership): don't import `MonoidWithZero` (#20748)
  refactor(Algebra/Algebra/Pi): cleanup and renaming (#21213)
  feat(GroupTheory/IndexNormal): subgroups of small index are normal (#21186)
  feat(Algebra/Group/Action): add definition of equidecomposition (#16936)
  feat(CategoryTheory/Subpresheaf): equalizer (#21096)
  feat: add lemmas about products of `Matrix.stdBasisMatrix` (#21204)
  chore: update Mathlib dependencies 2025-01-31 (#21282)
  ...
jt496 pushed a commit that referenced this pull request Feb 3, 2025
Define equidecomposition and provide some basic theory and operations.

[Zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Banach.20Tarski.20Paradox.20in.20Lean)



Co-authored-by: Felix-Weilacher <fweilach@andrew.cmu.edu>
Co-authored-by: Tristan F. <LeoDog896@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants