Skip to content

[Merged by Bors] - feat(Analysis/NormedSpace/FunctionSeries): add eventually versions#16543

Closed
CBirkbeck wants to merge 21 commits intomasterfrom
tsum_unif_eventually
Closed

[Merged by Bors] - feat(Analysis/NormedSpace/FunctionSeries): add eventually versions#16543
CBirkbeck wants to merge 21 commits intomasterfrom
tsum_unif_eventually

Conversation

@CBirkbeck
Copy link
Copy Markdown
Collaborator


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 6, 2024

PR summary a8208199bb

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ tendstoUniformlyOn_tsum_of_cofinite_eventually
+ tendstoUniformly_tsum_of_cofinite_eventually

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Current commit pr_summary
Reference commit 06851636bc

Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Stylistic comments below

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-author A reviewer has asked the author a question or requested changes. label Sep 6, 2024
CBirkbeck and others added 10 commits September 7, 2024 17:19
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@CBirkbeck CBirkbeck removed the awaiting-author A reviewer has asked the author a question or requested changes. label Sep 7, 2024
@kim-em kim-em added the t-analysis Analysis (normed *, calculus) label Sep 9, 2024
@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-author A reviewer has asked the author a question or requested changes. label Sep 17, 2024
CBirkbeck and others added 3 commits October 13, 2024 15:55
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@CBirkbeck CBirkbeck removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 13, 2024

/-- An infinite sum of functions with eventually summable sup norm is the uniform limit of its
partial sums. Version relative to a set, with index set `ℕ`. -/
theorem tendstoUniformlyOn_tsum_nat_eventually {α F : Type*} [NormedAddCommGroup F]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CAn you multiplicativise?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So like tendstoUniformlyOn_tsum it depends on norm_tsum_le_tsum_norm, which I also dont think we have a multiplicative version of (I could be wrong). I think adding these versions (where possible) would go outside the scope of this PR.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm okay 😦

@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 2, 2024
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@CBirkbeck CBirkbeck removed the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 12, 2024
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Nov 12, 2024
@j-loreaux j-loreaux added awaiting-author A reviewer has asked the author a question or requested changes. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Nov 12, 2024
@CBirkbeck CBirkbeck removed the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 19, 2024
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Nov 28, 2024
mathlib-bors bot pushed a commit that referenced this pull request Nov 28, 2024
…16543)

Co-authored-by: Chris Birkbeck <c.birkbeck@uea.ac.uk>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 28, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Analysis/NormedSpace/FunctionSeries): add eventually versions [Merged by Bors] - feat(Analysis/NormedSpace/FunctionSeries): add eventually versions Nov 28, 2024
@mathlib-bors mathlib-bors bot closed this Nov 28, 2024
@mathlib-bors mathlib-bors bot deleted the tsum_unif_eventually branch November 28, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants