[Merged by Bors] - doc: Improve documentation of ordinal-indexed approximations#16406
Closed
PhoenixIra wants to merge 9 commits intomasterfrom
Closed
[Merged by Bors] - doc: Improve documentation of ordinal-indexed approximations#16406PhoenixIra wants to merge 9 commits intomasterfrom
PhoenixIra wants to merge 9 commits intomasterfrom
Conversation
added 2 commits
September 2, 2024 09:38
PR summary 6b82842bdcImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
vihdzp
reviewed
Sep 2, 2024
Collaborator
vihdzp
left a comment
There was a problem hiding this comment.
These new docstrings are definitely clearer. I've left a few spell-checking remarks as well as more opinionated suggestions (which all apply dually to gfpApprox).
YaelDillies
reviewed
Sep 24, 2024
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Collaborator
|
Oh, I'm sorry! I thought this was my PR for a sec... |
Collaborator
Author
|
I appreciate the help anyway! |
YaelDillies
reviewed
Sep 25, 2024
Contributor
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Member
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
As mentioned in #15522, the documentation uses heavily the wording "ordinal approximation", which suggests that ordinals are approximated. This PR changes it to "ordinal-indexed approximation" and highlights the indexed nature of ordinals in various places. It also fixes some apparent then vs than errors. I appreciate any suggestions to further improve the documentation and hints for spelling mistakes. [](https://gitpod.io/from-referrer/) Co-authored-by: Violeta Hernández <vi.hdz.p@gmail.com> Co-authored-by: Ira Fesefeldt <public@feuervogel.me>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
dagurtomas
pushed a commit
that referenced
this pull request
Sep 25, 2024
As mentioned in #15522, the documentation uses heavily the wording "ordinal approximation", which suggests that ordinals are approximated. This PR changes it to "ordinal-indexed approximation" and highlights the indexed nature of ordinals in various places. It also fixes some apparent then vs than errors. I appreciate any suggestions to further improve the documentation and hints for spelling mistakes. [](https://gitpod.io/from-referrer/) Co-authored-by: Violeta Hernández <vi.hdz.p@gmail.com> Co-authored-by: Ira Fesefeldt <public@feuervogel.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #15522, the documentation uses heavily the wording "ordinal approximation", which suggests that ordinals are approximated. This PR changes it to "ordinal-indexed approximation" and highlights the indexed nature of ordinals in various places. It also fixes some apparent then vs than errors.
I appreciate any suggestions to further improve the documentation and hints for spelling mistakes.