[Merged by Bors] - chore(CategoryTheory/Sites): remove unused lemmas and simplify some proofs in Sites.Discrete#16385
Closed
dagurtomas wants to merge 7 commits intomasterfrom
Closed
[Merged by Bors] - chore(CategoryTheory/Sites): remove unused lemmas and simplify some proofs in Sites.Discrete#16385dagurtomas wants to merge 7 commits intomasterfrom
dagurtomas wants to merge 7 commits intomasterfrom
Conversation
…roofs in Sites.Discrete
PR summary aa22c849a9
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.CategoryTheory.Sites.Discrete | 891 | 0 | -891 (-100.00%) |
| Mathlib.CategoryTheory.Sites.ConstantSheaf | 672 | 890 | +218 (+32.44%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.CategoryTheory.Sites.Discrete |
-891 |
Mathlib.CategoryTheory.Sites.SheafCohomology.Basic |
126 |
Mathlib.CategoryTheory.Sites.ConstantSheaf |
218 |
Declarations diff
+ IsConstant
+ Sheaf.isConstant_iff_forget
+ Sheaf.isConstant_iff_of_equivalence
+ Sheaf.isConstant_of_forget
+ constantCommuteCompose_hom_app_val
+ constantSheafAdj_counit_w
+ instance [(constantSheaf J D).Faithful] [(constantSheaf J D).Full] (F : Sheaf J D)
+ instance [h : F.IsConstant J] : ((sheafCompose J U).obj F).IsConstant J := by
+ isConstant_congr
+ isConstant_iff_isIso_counit_app
+ isConstant_iff_isIso_counit_app'
+ isConstant_iff_mem_essImage
+ isConstant_of_isIso_counit_app
+ isConstant_of_iso
+ mem_essImage_of_isConstant
- IsDiscrete
- constantCommuteComposeApp_comp_counit
- constantSheafAdj_counit_app
- instance [h : F.IsDiscrete J ht] : ((sheafCompose J U).obj F).IsDiscrete J ht := by
- isDiscrete_iff_forget
- isDiscrete_iff_isIso_counit_app
- isDiscrete_iff_mem_essImage
- isDiscrete_iff_mem_essImage'
- isDiscrete_iff_of_equivalence
- isDiscrete_of_iso
- sheafComposeNatIso_app_counit
- sheafCompose_reflects_discrete
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
joelriou
reviewed
Sep 1, 2024
joelriou
reviewed
Sep 1, 2024
3 tasks
joelriou
reviewed
Sep 2, 2024
joelriou
reviewed
Sep 2, 2024
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
joelriou
reviewed
Sep 2, 2024
Contributor
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
…roofs in Sites.Discrete (#16385) This PR does the following - Renames `Sheaf.IsDiscrete` to `Sheaf.IsConstant` and changes the definition to being in the essential image of the constant sheaf functor instead of requiring the counit to be an isomorphism. - Removes two lemmas from the file `Sites.Discrete` which were essentially duplicates of other ones, and simplifies a proof to be able to remove an auxiliary lemma. - Moves the remaining contets of `Sites.Discrete` to the file `Sites.ConstantSheaf`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
…roofs in Sites.Discrete (#16385) This PR does the following - Renames `Sheaf.IsDiscrete` to `Sheaf.IsConstant` and changes the definition to being in the essential image of the constant sheaf functor instead of requiring the counit to be an isomorphism. - Removes two lemmas from the file `Sites.Discrete` which were essentially duplicates of other ones, and simplifies a proof to be able to remove an auxiliary lemma. - Moves the remaining contets of `Sites.Discrete` to the file `Sites.ConstantSheaf`.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
…roofs in Sites.Discrete (#16385) This PR does the following - Renames `Sheaf.IsDiscrete` to `Sheaf.IsConstant` and changes the definition to being in the essential image of the constant sheaf functor instead of requiring the counit to be an isomorphism. - Removes two lemmas from the file `Sites.Discrete` which were essentially duplicates of other ones, and simplifies a proof to be able to remove an auxiliary lemma. - Moves the remaining contets of `Sites.Discrete` to the file `Sites.ConstantSheaf`.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
…roofs in Sites.Discrete (#16385) This PR does the following - Renames `Sheaf.IsDiscrete` to `Sheaf.IsConstant` and changes the definition to being in the essential image of the constant sheaf functor instead of requiring the counit to be an isomorphism. - Removes two lemmas from the file `Sites.Discrete` which were essentially duplicates of other ones, and simplifies a proof to be able to remove an auxiliary lemma. - Moves the remaining contets of `Sites.Discrete` to the file `Sites.ConstantSheaf`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following
Sheaf.IsDiscretetoSheaf.IsConstantand changes the definition to being in the essential image of the constant sheaf functor instead of requiring the counit to be an isomorphism.Sites.Discretewhich were essentially duplicates of other ones, and simplifies a proof to be able to remove an auxiliary lemma.Sites.Discreteto the fileSites.ConstantSheaf.I added these lemmas initially because I used them in #14027, but it turns out they're essentially duplicates of other lemmas, now merged into one lemma
constantSheafAdj_counit_wwhich is used in this file and in #14027.