Skip to content

[Merged by Bors] - feat: add bot_not_mem_iff for OrderBot#16336

Closed
j-loreaux wants to merge 2 commits intomasterfrom
j-loreaux/bot_not_mem_iff
Closed

[Merged by Bors] - feat: add bot_not_mem_iff for OrderBot#16336
j-loreaux wants to merge 2 commits intomasterfrom
j-loreaux/bot_not_mem_iff

Conversation

@j-loreaux
Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux commented Aug 30, 2024

Open in Gitpod

@j-loreaux j-loreaux added the t-order Order theory label Aug 30, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 30, 2024 •
edited
Loading

PR summary 45b058d8ed

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ bot_not_mem_iff
+ one_not_mem_iff
+ top_not_mem_iff

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@j-loreaux j-loreaux added the easy < 20s of review time. See the lifecycle page for guidelines. label Aug 30, 2024
Ruben-VandeVelde
Ruben-VandeVelde approved these changes Aug 31, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@j-loreaux @Ruben-VandeVelde
Update Mathlib/Order/BoundedOrder.lean
45b058d 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@j-loreaux j-loreaux mentioned this pull request Aug 31, 2024
Closed
7 tasks
@dupuisf
Copy link
Copy Markdown
Contributor

dupuisf commented Aug 31, 2024

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 31, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 31, 2024
@j-loreaux
feat: add bot_not_mem_iff for OrderBot (#16336)
e60050d
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 31, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: add bot_not_mem_iff for OrderBot [Merged by Bors] - feat: add bot_not_mem_iff for OrderBot Aug 31, 2024
@mathlib-bors mathlib-bors bot closed this Aug 31, 2024
@mathlib-bors mathlib-bors bot deleted the j-loreaux/bot_not_mem_iff branch August 31, 2024 21:14
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
@j-loreaux @bjoernkjoshanssen
feat: add bot_not_mem_iff for OrderBot (#16336)
e489aac
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
@j-loreaux @bjoernkjoshanssen
feat: add bot_not_mem_iff for OrderBot (#16336)
a8be57a
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
@j-loreaux @bjoernkjoshanssen
feat: add bot_not_mem_iff for OrderBot (#16336)
daaaae5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees

No one assigned

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-order Order theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@j-loreaux @dupuisf @Ruben-VandeVelde