[Merged by Bors] - feat(ENNReal): Scalar multiplication by NNReal is finite#16319
Closed
YaelDillies wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - feat(ENNReal): Scalar multiplication by NNReal is finite#16319YaelDillies wants to merge 4 commits intomasterfrom
NNReal is finite#16319YaelDillies wants to merge 4 commits intomasterfrom
Conversation
From LeanAPAP Co-authored-by: Bhavik Mehta <bhavik.mehta8@gmail.com>
PR summary ede1a90bb0
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Data.ENNReal.Operations | 760 | 761 | +1 (+0.13%) |
Import changes for all files
| Files | Import difference |
|---|---|
9 filesMathlib.Data.ENNReal.Inv Mathlib.Data.Real.ConjExponents Mathlib.Topology.EMetricSpace.Defs Mathlib.Topology.MetricSpace.Defs Mathlib.Data.ENNReal.Real Mathlib.Data.ENNReal.Operations Mathlib.Data.Real.EReal Mathlib.Topology.MetricSpace.Pseudo.Defs Mathlib.Topology.MetricSpace.MetricSeparated |
1 |
Declarations diff
+ mk_one
+ mk_zero
+ nnreal_smul_lt_top
+ nnreal_smul_lt_top_iff
+ nnreal_smul_ne_top
+ nnreal_smul_ne_top_iff
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
b-mehta
approved these changes
Aug 30, 2024
Contributor
b-mehta
left a comment
There was a problem hiding this comment.
I wrote part of this so I won't merge, but LGTM.
Comment on lines
+158
to
+159
| @[simp] lemma mk_zero : (⟨0, le_rfl⟩ : ℝ≥0) = 0 := rfl | ||
| @[simp] lemma mk_one : (⟨1, zero_le_one⟩ : ℝ≥0) = 1 := rfl |
Contributor
There was a problem hiding this comment.
Maybe these should be protected
Contributor
Author
There was a problem hiding this comment.
Other similarly named lemmas are not protected, so I don't think so
Ruben-VandeVelde
approved these changes
Aug 31, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Member
|
Thanks! 🎉 |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 31, 2024
From LeanAPAP Co-authored-by: Bhavik Mehta <bhavik.mehta8@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
NNReal is finiteNNReal is finite
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
From LeanAPAP Co-authored-by: Bhavik Mehta <bhavik.mehta8@gmail.com>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
From LeanAPAP Co-authored-by: Bhavik Mehta <bhavik.mehta8@gmail.com>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
From LeanAPAP Co-authored-by: Bhavik Mehta <bhavik.mehta8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From LeanAPAP
Co-authored-by: Bhavik Mehta bhavik.mehta8@gmail.com