Skip to content

[Merged by Bors] - chore(CategoryTheory/Sites): remove some erws#16312

Closed
dagurtomas wants to merge 2 commits intomasterfrom
dagur/SitesCleanup
Closed

[Merged by Bors] - chore(CategoryTheory/Sites): remove some erws#16312
dagurtomas wants to merge 2 commits intomasterfrom
dagur/SitesCleanup

Conversation

@dagurtomas
Copy link
Copy Markdown
Contributor

@dagurtomas dagurtomas commented Aug 30, 2024

...also a few unnecessary dsimps and other cleanup


Open in Gitpod

@dagurtomas dagurtomas added t-category-theory Category theory tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Aug 30, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 30, 2024

PR summary 1f9dd57664

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@joelriou
Copy link
Copy Markdown
Contributor

!bench

@joelriou
Copy link
Copy Markdown
Contributor

(I would like to see if some dsimp; simp were better than just simp.)

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit 1f9dd57.
There were no significant changes against commit 283ca40.

@joelriou
Copy link
Copy Markdown
Contributor

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 30, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 30, 2024
...also a few unnecessary `dsimps` and other cleanup
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 30, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(CategoryTheory/Sites): remove some erws [Merged by Bors] - chore(CategoryTheory/Sites): remove some erws Aug 30, 2024
@mathlib-bors mathlib-bors bot closed this Aug 30, 2024
@mathlib-bors mathlib-bors bot deleted the dagur/SitesCleanup branch August 30, 2024 16:28
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
...also a few unnecessary `dsimps` and other cleanup
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
...also a few unnecessary `dsimps` and other cleanup
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
...also a few unnecessary `dsimps` and other cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-category-theory Category theory tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants