[Merged by Bors] - fix(lint-style.py): recognise all kinds of style exceptions#16297
Closed
[Merged by Bors] - fix(lint-style.py): recognise all kinds of style exceptions#16297
Conversation
PR summary 0c387bcf7aImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
Not recognising one is more confusing than any other behaviour. In practice, after #15610 none of these should be needed in practice.
35b62b7 to
0c387bc
Compare
Contributor
|
Thanks! maintainer merge If I understand correctly, the general trend is to eliminate all the error codes that are maintained by the python/bash linters. However, this means that if for some reason one of these error codes creeps up again, the script will not be confused, right? |
|
🚀 Pull request has been placed on the maintainer queue by adomani. |
Contributor
Author
|
To clarify: all errors added are maintained by In the medium-term, I would propose removing |
Member
|
Thanks! 🎉 |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 31, 2024
Currently, some style exceptions emitted by the `lint-style.py` script are not recognised by that same script. This can lead to confusing behaviour. That said, all current exceptions should rather be fixed than excepted - so this is unlikely to be an issue in practice.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
Currently, some style exceptions emitted by the `lint-style.py` script are not recognised by that same script. This can lead to confusing behaviour. That said, all current exceptions should rather be fixed than excepted - so this is unlikely to be an issue in practice.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
Currently, some style exceptions emitted by the `lint-style.py` script are not recognised by that same script. This can lead to confusing behaviour. That said, all current exceptions should rather be fixed than excepted - so this is unlikely to be an issue in practice.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
Currently, some style exceptions emitted by the `lint-style.py` script are not recognised by that same script. This can lead to confusing behaviour. That said, all current exceptions should rather be fixed than excepted - so this is unlikely to be an issue in practice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, some style exceptions emitted by the
lint-style.pyscript are not recognised by that same script. This can lead to confusing behaviour.That said, all current exceptions should rather be fixed than excepted - so this is unlikely to be an issue in practice.