[Merged by Bors] - chore(Init/Data/Quot): better naming#16252
Closed
astrainfinita wants to merge 1 commit intomasterfrom
Closed
[Merged by Bors] - chore(Init/Data/Quot): better naming#16252astrainfinita wants to merge 1 commit intomasterfrom
astrainfinita wants to merge 1 commit intomasterfrom
Conversation
PR summary 208c7e2c36
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Init.Data.Quot | 1 | 2 | +1 (+100.00%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Init.Data.Quot |
1 |
Declarations diff
+ Quot.eqvGen_exact
+ Quot.eqvGen_sound
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
Ruben-VandeVelde
approved these changes
Aug 31, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
lgtm
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Member
|
Thanks! 🎉 |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 31, 2024
`Quot.exact` ↦ `Quot.eqvGen_exact` `Quot.EqvGen_sound` ↦ `Quot.eqvGen_sound`
Contributor
|
Pull request successfully merged into master. Build succeeded: |
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
`Quot.exact` ↦ `Quot.eqvGen_exact` `Quot.EqvGen_sound` ↦ `Quot.eqvGen_sound`
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
`Quot.exact` ↦ `Quot.eqvGen_exact` `Quot.EqvGen_sound` ↦ `Quot.eqvGen_sound`
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
`Quot.exact` ↦ `Quot.eqvGen_exact` `Quot.EqvGen_sound` ↦ `Quot.eqvGen_sound`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quot.exact↦Quot.eqvGen_exactQuot.EqvGen_sound↦Quot.eqvGen_sound