Skip to content

[Merged by Bors] - feat: A star group is a star -module#16246

Closed
YaelDillies wants to merge 1 commit intomasterfrom
star_module_int
Closed

[Merged by Bors] - feat: A star group is a star -module#16246
YaelDillies wants to merge 1 commit intomasterfrom
star_module_int

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

From LeanAPAP


Open in Gitpod

@YaelDillies YaelDillies added easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc) labels Aug 29, 2024
@YaelDillies YaelDillies requested a review from b-mehta August 29, 2024 09:17
@github-actions
Copy link
Copy Markdown

PR summary 89c062ba5b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ StarAddMonoid.toStarModuleInt

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 29, 2024
@b-mehta
Copy link
Copy Markdown
Contributor

b-mehta commented Aug 30, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 30, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 30, 2024
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 30, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: A star group is a star -module [Merged by Bors] - feat: A star group is a star -module Aug 30, 2024
@mathlib-bors mathlib-bors bot closed this Aug 30, 2024
@mathlib-bors mathlib-bors bot deleted the star_module_int branch August 30, 2024 18:39
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants