Skip to content

[Merged by Bors] - chore: add the stacks attribute and extension#16191

Closed
adomani wants to merge 24 commits intomasterfrom
adomani/stacks_attribute_and_extension
Closed

[Merged by Bors] - chore: add the stacks attribute and extension#16191
adomani wants to merge 24 commits intomasterfrom
adomani/stacks_attribute_and_extension

Conversation

@adomani
Copy link
Copy Markdown
Contributor

@adomani adomani commented Aug 27, 2024

This extends the simple attribute of #16179 with an environment extension that tracks also the declaration names and tags.

The #stacks_tags command retrieves all declarations that have the stacks attribute.

For each found declaration, it prints a line

'declaration_name' corresponds to tag 'declaration_tag'.

The variant #stacks_tags! also adds the theorem statement after each summary line.

Zulip thread


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 27, 2024

PR summary d05ab34bd0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Tactic.StacksAttribute Mathlib.Tactic 1

Declarations diff

+ Lean.Environment.getSortedStackProjectDeclNames
+ Lean.Environment.getSortedStackProjectTags
+ Tag
+ addTagEntry
+ tagged

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@mergify
Copy link
Copy Markdown

mergify bot commented Aug 27, 2024

⚠️ The sha of the head commit of this PR conflicts with #16179. Mergify cannot evaluate rules on this PR. ⚠️

@adomani adomani added the t-meta Tactics, attributes or user commands label Aug 27, 2024
@adomani adomani changed the title chore: add the stacks attribute chore: add the stacks attribute and extension Aug 27, 2024
@mattrobball
Copy link
Copy Markdown
Contributor

Looks great! Can you fix the failing docBlame?

Copy link
Copy Markdown
Contributor Author

@adomani adomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matt, thanks for the review! I should have taken care of cleaning up the left-overs!

@mattrobball
Copy link
Copy Markdown
Contributor

Ok. I am ready to merge when CI is green.

@mattrobball
Copy link
Copy Markdown
Contributor

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 27, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 27, 2024
This extends the simple attribute of #16179 with an environment extension that tracks also the declaration names and tags.

The `#stacks_tags` command retrieves all declarations that have the `stacks` attribute.

For each found declaration, it prints a line
```
'declaration_name' corresponds to tag 'declaration_tag'.
```
The variant `#stacks_tags!` also adds the theorem statement after each summary line.

[Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/stacks.20tags)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 27, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: add the stacks attribute and extension [Merged by Bors] - chore: add the stacks attribute and extension Aug 27, 2024
@mathlib-bors mathlib-bors bot closed this Aug 27, 2024
@mathlib-bors mathlib-bors bot deleted the adomani/stacks_attribute_and_extension branch August 27, 2024 21:24
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
This extends the simple attribute of #16179 with an environment extension that tracks also the declaration names and tags.

The `#stacks_tags` command retrieves all declarations that have the `stacks` attribute.

For each found declaration, it prints a line
```
'declaration_name' corresponds to tag 'declaration_tag'.
```
The variant `#stacks_tags!` also adds the theorem statement after each summary line.

[Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/stacks.20tags)
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
This extends the simple attribute of #16179 with an environment extension that tracks also the declaration names and tags.

The `#stacks_tags` command retrieves all declarations that have the `stacks` attribute.

For each found declaration, it prints a line
```
'declaration_name' corresponds to tag 'declaration_tag'.
```
The variant `#stacks_tags!` also adds the theorem statement after each summary line.

[Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/stacks.20tags)
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
This extends the simple attribute of #16179 with an environment extension that tracks also the declaration names and tags.

The `#stacks_tags` command retrieves all declarations that have the `stacks` attribute.

For each found declaration, it prints a line
```
'declaration_name' corresponds to tag 'declaration_tag'.
```
The variant `#stacks_tags!` also adds the theorem statement after each summary line.

[Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/stacks.20tags)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants