[Merged by Bors] - feat: generalize universes in preservesFiniteProductsOfPreservesBinaryAndTerminal#16178
Closed
callesonne wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - feat: generalize universes in preservesFiniteProductsOfPreservesBinaryAndTerminal#16178callesonne wants to merge 2 commits intomasterfrom
preservesFiniteProductsOfPreservesBinaryAndTerminal#16178callesonne wants to merge 2 commits intomasterfrom
Conversation
PR summary a79abb66ecImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
1 task
Contributor
|
In this direction, this is an obvious improvement. Thanks! maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by dagurtomas. |
preservesFiniteProductsOfPreservesBinaryAndTerminal
Contributor
|
bors merge |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
preservesFiniteProductsOfPreservesBinaryAndTerminalpreservesFiniteProductsOfPreservesBinaryAndTerminal
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed some theorems that hold with more general universe parameters than given. Since this is just a generalization of a lemma, I assume there is no harm in doing this?