Skip to content

[Merged by Bors] - chore(SimpleGraph): fix DecidableEq/Fintype assumptions#16079

Closed
urkud wants to merge 2 commits intomasterfrom
YK-graph-dec
Closed

[Merged by Bors] - chore(SimpleGraph): fix DecidableEq/Fintype assumptions#16079
urkud wants to merge 2 commits intomasterfrom
YK-graph-dec

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Aug 23, 2024

Found by a linter in #10235
Mostly repeats @grunweg's #15306 accidentally reverted by @semorrison's #15726


Open in Gitpod

Found by a linter in #10235
Mostly repeats #15306 accidentally reverted by #15726
@urkud urkud added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Aug 23, 2024
@urkud urkud requested a review from grunweg August 23, 2024 01:25
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 23, 2024

PR summary cd5e4d8f09

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@urkud urkud added the easy < 20s of review time. See the lifecycle page for guidelines. label Aug 23, 2024
@dupuisf
Copy link
Copy Markdown
Contributor

dupuisf commented Aug 23, 2024

Thanks!

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 23, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 23, 2024
Found by a linter in #10235
Mostly repeats @grunweg's  #15306 accidentally reverted by @semorrison's #15726
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 23, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(SimpleGraph): fix DecidableEq/Fintype assumptions [Merged by Bors] - chore(SimpleGraph): fix DecidableEq/Fintype assumptions Aug 23, 2024
@mathlib-bors mathlib-bors bot closed this Aug 23, 2024
@mathlib-bors mathlib-bors bot deleted the YK-graph-dec branch August 23, 2024 03:01
@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Aug 23, 2024

And this PR is merged before I even open my computer to look at recent mathlib notifications :-)

bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
Found by a linter in #10235
Mostly repeats @grunweg's  #15306 accidentally reverted by @semorrison's #15726
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
Found by a linter in #10235
Mostly repeats @grunweg's  #15306 accidentally reverted by @semorrison's #15726
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
Found by a linter in #10235
Mostly repeats @grunweg's  #15306 accidentally reverted by @semorrison's #15726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants