[Merged by Bors] - fix: error positioning in linear_combination#16072
Closed
[Merged by Bors] - fix: error positioning in linear_combination#16072
linear_combination#16072Conversation
PR summary d22b8261c5Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
eric-wieser
reviewed
Aug 22, 2024
eric-wieser
approved these changes
Aug 22, 2024
Member
eric-wieser
left a comment
There was a problem hiding this comment.
bors d+
We can cleanup the Unhygienic.run in a later PR after hearing from Mario on Zulip.
Contributor
|
✌️ hrmacbeth can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
A tweak to `linear_combination` so that when the default normalization tactic fails, the "red underlines" appear on the `linear_combination` call itself, rather than just on the "by" at the start of the proof. For example, compare before/after on this example:
```lean
import Mathlib
example {a : ℤ} (h : a = 1) : a = 2 := by
linear_combination h
```
Zulip discussion:
https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/Propagating.20errors.20through.20Unhygienic.2Erun
Contributor
|
Pull request successfully merged into master. Build succeeded: |
linear_combinationlinear_combination
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
A tweak to `linear_combination` so that when the default normalization tactic fails, the "red underlines" appear on the `linear_combination` call itself, rather than just on the "by" at the start of the proof. For example, compare before/after on this example:
```lean
import Mathlib
example {a : ℤ} (h : a = 1) : a = 2 := by
linear_combination h
```
Zulip discussion:
https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/Propagating.20errors.20through.20Unhygienic.2Erun
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
A tweak to `linear_combination` so that when the default normalization tactic fails, the "red underlines" appear on the `linear_combination` call itself, rather than just on the "by" at the start of the proof. For example, compare before/after on this example:
```lean
import Mathlib
example {a : ℤ} (h : a = 1) : a = 2 := by
linear_combination h
```
Zulip discussion:
https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/Propagating.20errors.20through.20Unhygienic.2Erun
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
A tweak to `linear_combination` so that when the default normalization tactic fails, the "red underlines" appear on the `linear_combination` call itself, rather than just on the "by" at the start of the proof. For example, compare before/after on this example:
```lean
import Mathlib
example {a : ℤ} (h : a = 1) : a = 2 := by
linear_combination h
```
Zulip discussion:
https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/Propagating.20errors.20through.20Unhygienic.2Erun
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tweak to
linear_combinationso that when the default normalization tactic fails, the "red underlines" appear on thelinear_combinationcall itself, rather than just on the "by" at the start of the proof. For example, compare before/after on this example:Zulip discussion:
https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/Propagating.20errors.20through.20Unhygienic.2Erun