Skip to content

[Merged by Bors] - feat(CategoryTheory/Adjunction): dualize adjoint lifting theorem#16066

Closed
dagurtomas wants to merge 7 commits intomasterfrom
dagur/AdjointLiftingRight
Closed

[Merged by Bors] - feat(CategoryTheory/Adjunction): dualize adjoint lifting theorem#16066
dagurtomas wants to merge 7 commits intomasterfrom
dagur/AdjointLiftingRight

Conversation

@dagurtomas
Copy link
Copy Markdown
Contributor

@dagurtomas dagurtomas commented Aug 22, 2024 •
edited
Loading

This PR renames the file CategoryTheory.Adjunction.Lifting to CategoryTheory.Adjunction.Lifting.Left and dualizes it in a new file CategoryTheory.Adjunction.Lifting.Right to lift right adjoints through comonads.

It also changes some names in the original file which didn't follow naming conventions, as well as renaming the implementation namespace.

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 22, 2024 •
edited
Loading

PR summary 6c8a50c503

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.CategoryTheory.Adjunction.Lifting -549
Mathlib.CategoryTheory.Adjunction.Lifting.Left Mathlib.CategoryTheory.Adjunction.Lifting.Right 549

Declarations diff

+ constructRightAdjoint
+ constructRightAdjointEquiv
+ constructRightAdjointObj
+ instance (X : B) :
+ isLeftAdjoint_square_lift
+ isLeftAdjoint_square_lift_comonadic
+ isLeftAdjoint_triangle_lift
+ isLeftAdjoint_triangle_lift_comonadic
+ isRightAdjoint_square_lift
+ isRightAdjoint_square_lift_monadic
+ isRightAdjoint_triangle_lift
+ isRightAdjoint_triangle_lift_monadic
+ otherMap
+ unitEqualises
- adjointSquareLift
- adjointTriangleLift
- monadicAdjointSquareLift
- monadicAdjointTriangleLift

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@dagurtomas dagurtomas added the t-category-theory Category theory label Aug 22, 2024
@dagurtomas dagurtomas mentioned this pull request Aug 22, 2024
Closed
1 task
callesonne
callesonne approved these changes Aug 25, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@callesonne callesonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not had a look at the proofs, but since this just dualizes the other file LGTM!

dagurtomas and others added 2 commits August 26, 2024 08:19
@dagurtomas @callesonne
Apply suggestions from code review
bc5f9db 
Co-authored-by: Calle Sönne <calle.sonne@gmail.com>
@dagurtomas
suggestions from Calle
6c8a50c
@dagurtomas
Copy link
Copy Markdown
Contributor Author

dagurtomas commented Aug 26, 2024

Thanks for the review! BTW you should add the awaiting-author label when you suggest changes or make comments the author has to respond to, to temporarily remove the PR from the queue, reducing clutter for other reviewers.

jcommelin
jcommelin reviewed Sep 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Sep 3, 2024
mathlib-bors bot pushed a commit that referenced this pull request Sep 3, 2024
@dagurtomas
feat(CategoryTheory/Adjunction): dualize adjoint lifting theorem (#16066
9ca5d4d 
)

This PR renames the file `CategoryTheory.Adjunction.Lifting` to `CategoryTheory.Adjunction.Lifting.Left` and dualizes it in a new file `CategoryTheory.Adjunction.Lifting.Right` to lift right adjoints through comonads.

It also changes some names in the original file which didn't follow naming conventions, as well as renaming the implementation namespace.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 3, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory/Adjunction): dualize adjoint lifting theorem [Merged by Bors] - feat(CategoryTheory/Adjunction): dualize adjoint lifting theorem Sep 3, 2024
@mathlib-bors mathlib-bors bot closed this Sep 3, 2024
@mathlib-bors mathlib-bors bot deleted the dagur/AdjointLiftingRight branch September 3, 2024 10:09
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
@dagurtomas @bjoernkjoshanssen
feat(CategoryTheory/Adjunction): dualize adjoint lifting theorem (#16066
b218dcd 
)

This PR renames the file `CategoryTheory.Adjunction.Lifting` to `CategoryTheory.Adjunction.Lifting.Left` and dualizes it in a new file `CategoryTheory.Adjunction.Lifting.Right` to lift right adjoints through comonads.

It also changes some names in the original file which didn't follow naming conventions, as well as renaming the implementation namespace.
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
@dagurtomas @bjoernkjoshanssen
feat(CategoryTheory/Adjunction): dualize adjoint lifting theorem (#16066
7e008a3 
)

This PR renames the file `CategoryTheory.Adjunction.Lifting` to `CategoryTheory.Adjunction.Lifting.Left` and dualizes it in a new file `CategoryTheory.Adjunction.Lifting.Right` to lift right adjoints through comonads.

It also changes some names in the original file which didn't follow naming conventions, as well as renaming the implementation namespace.
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
@dagurtomas @bjoernkjoshanssen
feat(CategoryTheory/Adjunction): dualize adjoint lifting theorem (#16066
9efc623 
)

This PR renames the file `CategoryTheory.Adjunction.Lifting` to `CategoryTheory.Adjunction.Lifting.Left` and dualizes it in a new file `CategoryTheory.Adjunction.Lifting.Right` to lift right adjoints through comonads.

It also changes some names in the original file which didn't follow naming conventions, as well as renaming the implementation namespace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcommelin jcommelin jcommelin left review comments

+1 more reviewer

@callesonne callesonne callesonne approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dagurtomas @jcommelin @callesonne