Skip to content

[Merged by Bors] - feat(Category/Cat): add API lemmas#16064

Closed
callesonne wants to merge 2 commits intomasterfrom
cat-API
Closed

[Merged by Bors] - feat(Category/Cat): add API lemmas#16064
callesonne wants to merge 2 commits intomasterfrom
cat-API

Conversation

@callesonne
Copy link
Copy Markdown
Collaborator

@callesonne callesonne commented Aug 22, 2024

This PR adds more API lemmas about the bicategory of categories Cat. These are added as simp is not able to use the corresponding NatTrans lemmas when working with 2-morphisms in the bicategory Cat.

Due to this some proofs in CategoryTheory/Grothendieck can be golfed.


Open in Gitpod

@callesonne callesonne added easy < 20s of review time. See the lifecycle page for guidelines. t-category-theory Category theory labels Aug 22, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 22, 2024

PR summary 8724d77953

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ comp_app
+ eqToHom_app
+ id_app
+ id_obj

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@joelriou
Copy link
Copy Markdown
Contributor

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 22, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 22, 2024
This PR adds more API lemmas about the bicategory of categories `Cat`. These are added as `simp` is not able to use the corresponding `NatTrans` lemmas when working with 2-morphisms in the bicategory `Cat`.

Due to this some proofs in `CategoryTheory/Grothendieck` can be golfed.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 22, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Category/Cat): add API lemmas [Merged by Bors] - feat(Category/Cat): add API lemmas Aug 22, 2024
@mathlib-bors mathlib-bors bot closed this Aug 22, 2024
@mathlib-bors mathlib-bors bot deleted the cat-API branch August 22, 2024 14:48
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
This PR adds more API lemmas about the bicategory of categories `Cat`. These are added as `simp` is not able to use the corresponding `NatTrans` lemmas when working with 2-morphisms in the bicategory `Cat`.

Due to this some proofs in `CategoryTheory/Grothendieck` can be golfed.
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
This PR adds more API lemmas about the bicategory of categories `Cat`. These are added as `simp` is not able to use the corresponding `NatTrans` lemmas when working with 2-morphisms in the bicategory `Cat`.

Due to this some proofs in `CategoryTheory/Grothendieck` can be golfed.
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
This PR adds more API lemmas about the bicategory of categories `Cat`. These are added as `simp` is not able to use the corresponding `NatTrans` lemmas when working with 2-morphisms in the bicategory `Cat`.

Due to this some proofs in `CategoryTheory/Grothendieck` can be golfed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants