Skip to content

[Merged by Bors] - fix: disable the haveLet linter#16058

Closed
adomani wants to merge 2 commits intomasterfrom
adomani/disable_haveLet_linter
Closed

[Merged by Bors] - fix: disable the haveLet linter#16058
adomani wants to merge 2 commits intomasterfrom
adomani/disable_haveLet_linter

Conversation

@adomani
Copy link
Copy Markdown
Contributor

@adomani adomani commented Aug 22, 2024

At least, until I fix a bug, reported both on Mathlib and on projects depending on Mathlib.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 22, 2024

PR summary 05f9d0cd0f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Aug 22, 2024

bors merge

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 22, 2024

Build failed:

@sgouezel
Copy link
Copy Markdown
Contributor

The build has failed. Can you fix the tests, and send it back to bors?
bors r-
bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 22, 2024

✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Aug 22, 2024
@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Aug 22, 2024

bors r+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 22, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix: disable the haveLet linter [Merged by Bors] - fix: disable the haveLet linter Aug 22, 2024
@mathlib-bors mathlib-bors bot closed this Aug 22, 2024
@mathlib-bors mathlib-bors bot deleted the adomani/disable_haveLet_linter branch August 22, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants