Skip to content

[Merged by Bors] - feat(Polynomial): eraseLead_add_of_degree_lt_left#16035

Closed
ChrisHughes24 wants to merge 4 commits intomasterfrom
CH_eraseLead_stuff
Closed

[Merged by Bors] - feat(Polynomial): eraseLead_add_of_degree_lt_left#16035
ChrisHughes24 wants to merge 4 commits intomasterfrom
CH_eraseLead_stuff

Conversation

@ChrisHughes24
Copy link
Copy Markdown
Member

@ChrisHughes24 ChrisHughes24 commented Aug 21, 2024

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 21, 2024

PR summary 4bbf894f95

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ eraseLead_add_of_degree_lt_left
+ eraseLead_add_of_degree_lt_right

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@ghost ghost added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Aug 21, 2024
@YaelDillies YaelDillies self-assigned this Aug 21, 2024
@ghost ghost removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Aug 21, 2024
@ghost
Copy link
Copy Markdown

ghost commented Aug 21, 2024

This PR/issue depends on:

Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to merge master to get the diff smaller. Otherwise looks good

@YaelDillies
Copy link
Copy Markdown
Contributor

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 22, 2024
@kbuzzard
Copy link
Copy Markdown
Member

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 22, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 22, 2024
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 22, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Polynomial): eraseLead_add_of_degree_lt_left [Merged by Bors] - feat(Polynomial): eraseLead_add_of_degree_lt_left Aug 22, 2024
@mathlib-bors mathlib-bors bot closed this Aug 22, 2024
@mathlib-bors mathlib-bors bot deleted the CH_eraseLead_stuff branch August 22, 2024 11:02
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants