[Merged by Bors] - chore: add missing end#15868
Closed
Conversation
Fix mathlib for running the missingEnd linter everywhere. Prerequiste to #15845.
PR summary 392c6c4c1dImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
adomani
approved these changes
Aug 16, 2024
|
🚀 Pull request has been placed on the maintainer queue by adomani. |
Contributor
Author
|
Good find, thanks! I tweaked some changes of this PR, trying to more closely follow "end namespaces how they were opened". |
Member
|
Thanks 🎉 bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
Fix mathlib for running the missingEnd linter everywhere. Prerequiste to #15845.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
Fix mathlib for running the missingEnd linter everywhere. Prerequiste to #15845.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
Fix mathlib for running the missingEnd linter everywhere. Prerequiste to #15845.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
Fix mathlib for running the missingEnd linter everywhere. Prerequiste to #15845.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix mathlib for running the missingEnd linter everywhere. Prerequiste to #15845.