Skip to content

[Merged by Bors] - feat(SetTheory/Game/Birthday): Define birthday of a game#15716

Closed
vihdzp wants to merge 53 commits intomasterfrom
game_birthday
Closed

[Merged by Bors] - feat(SetTheory/Game/Birthday): Define birthday of a game#15716
vihdzp wants to merge 53 commits intomasterfrom
game_birthday

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Aug 12, 2024

The updated module description explains how this differs from the birthday of a pre-game.


Open in Gitpod

@vihdzp vihdzp added the t-logic Logic (model theory, etc) label Aug 12, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 12, 2024

PR summary 682211c9d9

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.SetTheory.Game.Birthday 629 630 +1 (+0.16%)
Import changes for all files
Files Import difference
Mathlib.SetTheory.Game.Nim Mathlib.SetTheory.Game.Birthday 1

Declarations diff

+ birthday
+ birthday_add_le
+ birthday_eq_pGameBirthday
+ birthday_eq_zero
+ birthday_natCast
+ birthday_ofNat
+ birthday_one
+ birthday_ordinalToGame
+ birthday_ordinalToPGame
+ birthday_quot_le_pGameBirthday
+ birthday_star
+ birthday_sub
+ birthday_sub_le
+ birthday_zero
+ le_birthday
+ neg_birthday_le
+ quot_natCast
+ toGame_natCast
+ toPGame_natCast
+ zero_def
++ birthday_neg
- birthday_add_nat
- birthday_add_one
- birthday_add_zero
- birthday_nat_add
- birthday_nat_cast
- birthday_one_add
- birthday_zero_add
- neg_birthday
- toPGame_birthday

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@ghost ghost added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Aug 12, 2024
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Sep 8, 2024
vihdzp and others added 4 commits September 8, 2024 23:40
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@vihdzp vihdzp added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Sep 11, 2024
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Sep 11, 2024
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@YaelDillies
Copy link
Copy Markdown
Contributor

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Sep 11, 2024
@jcommelin jcommelin removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Sep 12, 2024
@YaelDillies
Copy link
Copy Markdown
Contributor

Eric's comment having been addressed,

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Sep 16, 2024
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Sep 16, 2024
mathlib-bors bot pushed a commit that referenced this pull request Sep 16, 2024
The updated module description explains how this differs from the birthday of a pre-game.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(SetTheory/Game/Birthday): Define birthday of a game [Merged by Bors] - feat(SetTheory/Game/Birthday): Define birthday of a game Sep 16, 2024
@mathlib-bors mathlib-bors bot closed this Sep 16, 2024
@mathlib-bors mathlib-bors bot deleted the game_birthday branch September 16, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants