[Merged by Bors] - chore: polishing the IMO solution 2024Q1#15714
Closed
[Merged by Bors] - chore: polishing the IMO solution 2024Q1#15714
Conversation
Collaborator
madvorak
commented
Aug 12, 2024
PR summary ff47b6d377Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
joneugster
approved these changes
Aug 14, 2024
Contributor
joneugster
left a comment
There was a problem hiding this comment.
Looks good, thanks!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by joneugster. |
jcommelin
reviewed
Aug 14, 2024
jcommelin
reviewed
Aug 14, 2024
Member
|
I would like to hear @jsm28 's opinion on these changes. |
jsm28
reviewed
Aug 14, 2024
Contributor
jsm28
left a comment
There was a problem hiding this comment.
I don't have any comments on these changes.
Contributor
|
Build failed: |
Member
|
Can you please merge master? Maybe that will make CI happy, or tell us why it is unhappy. |
Member
|
Thanks 🎉 bors merge |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.