Skip to content

[Merged by Bors] - chore(SetTheory/Game/Basic): fix Game.PGame namespace#15708

Closed
vihdzp wants to merge 2 commits intomasterfrom
pgame_game_fix
Closed

[Merged by Bors] - chore(SetTheory/Game/Basic): fix Game.PGame namespace#15708
vihdzp wants to merge 2 commits intomasterfrom
pgame_game_fix

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Aug 11, 2024

We move the Fuzzy definition so that the PGame namespace doesn't need to be opened twice. We also move the infix notation definition a bit later down the file.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary 21ab2bb58b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ equiv_iff_game_eq
+ fuzzy_iff_game_fuzzy
+ le_iff_game_le
+ lf_iff_game_lf
+ lt_iff_game_lt
- PGame.equiv_iff_game_eq
- PGame.fuzzy_iff_game_fuzzy
- PGame.le_iff_game_le
- PGame.lf_iff_game_lf
- PGame.lt_iff_game_lt

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the mess

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 11, 2024
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Aug 11, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 11, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 11, 2024
We move the `Fuzzy` definition so that the `PGame` namespace doesn't need to be opened twice. We also move the infix notation definition a bit later down the file.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 12, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(SetTheory/Game/Basic): fix Game.PGame namespace [Merged by Bors] - chore(SetTheory/Game/Basic): fix Game.PGame namespace Aug 12, 2024
@mathlib-bors mathlib-bors bot closed this Aug 12, 2024
@mathlib-bors mathlib-bors bot deleted the pgame_game_fix branch August 12, 2024 00:35
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
We move the `Fuzzy` definition so that the `PGame` namespace doesn't need to be opened twice. We also move the infix notation definition a bit later down the file.
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
We move the `Fuzzy` definition so that the `PGame` namespace doesn't need to be opened twice. We also move the infix notation definition a bit later down the file.
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
We move the `Fuzzy` definition so that the `PGame` namespace doesn't need to be opened twice. We also move the infix notation definition a bit later down the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants