[Merged by Bors] - perf(LinearAlgebra.Quotient): de-simp theorems with weak keys#15591
Closed
mattrobball wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - perf(LinearAlgebra.Quotient): de-simp theorems with weak keys#15591mattrobball wants to merge 2 commits intomasterfrom
mattrobball wants to merge 2 commits intomasterfrom
Conversation
Contributor
Author
|
!bench |
PR summary cb287abf83Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
Ruben-VandeVelde
approved these changes
Aug 7, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
Sounds reasonable.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Collaborator
|
Here are the benchmark results for commit 3c54320. Benchmark Metric Change
=======================================================
+ ~Mathlib.GroupTheory.CosetCover instructions -19.0% |
Contributor
Author
|
Reduction of linting instructions by 1% |
Submodule.Quotient.mk''_eq_mk
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit cb287ab. Benchmark Metric Change
=======================================================
+ ~Mathlib.GroupTheory.CosetCover instructions -19.0% |
Contributor
Author
|
Now actually over 1% reduction for linting instructions. |
1 task
Member
|
Thanks! 🎉 |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
For an example, the simp keys for `mk''_eq_mk` are `Quotient.mk'' _ _ _` meaning it will be tried on *anything* whose left-hand side reduces to `Quotient.mk''` regardless of the context. These are used a total of 6 times.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
For an example, the simp keys for `mk''_eq_mk` are `Quotient.mk'' _ _ _` meaning it will be tried on *anything* whose left-hand side reduces to `Quotient.mk''` regardless of the context. These are used a total of 6 times.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
For an example, the simp keys for `mk''_eq_mk` are `Quotient.mk'' _ _ _` meaning it will be tried on *anything* whose left-hand side reduces to `Quotient.mk''` regardless of the context. These are used a total of 6 times.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
For an example, the simp keys for `mk''_eq_mk` are `Quotient.mk'' _ _ _` meaning it will be tried on *anything* whose left-hand side reduces to `Quotient.mk''` regardless of the context. These are used a total of 6 times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an example, the simp keys for
mk''_eq_mkareQuotient.mk'' _ _ _meaning it will be tried on anything whose left-hand side reduces toQuotient.mk''regardless of the context. These are used a total of 6 times.