Skip to content

[Merged by Bors] - fix: undo the accidental revert of #11877 in #11807#15523

Closed
eric-wieser wants to merge 2 commits intomasterfrom
eric-wieser/remove-ProofWidgets-again
Closed

[Merged by Bors] - fix: undo the accidental revert of #11877 in #11807#15523
eric-wieser wants to merge 2 commits intomasterfrom
eric-wieser/remove-ProofWidgets-again

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser commented Aug 5, 2024

A bad merge in #11807 causes the change from #11877 (removing import ProofWidgets) to be reverted.


Open in Gitpod

A bad merge in #11807 causes the change from #11877 to be reverted.
@eric-wieser eric-wieser requested a review from adomani August 5, 2024 14:35
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 5, 2024

PR summary 8d6dbc566e

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Tactic.Common 235 234 -1 (-0.43%)
Import changes for all files
Files Import difference
There are 4040 files with changed transitive imports: this is too many to display!

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@eric-wieser eric-wieser added the easy < 20s of review time. See the lifecycle page for guidelines. label Aug 5, 2024
@adomani
Copy link
Copy Markdown
Contributor

adomani commented Aug 5, 2024

Thanks!

Assuming that CI is successful,

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 5, 2024

🚀 Pull request has been placed on the maintainer queue by adomani.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 5, 2024
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 6, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 6, 2024
A bad merge in #11807 causes the change from #11877 (removing `import ProofWidgets`) to be reverted.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 6, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix: undo the accidental revert of #11877 in #11807 [Merged by Bors] - fix: undo the accidental revert of #11877 in #11807 Aug 6, 2024
@mathlib-bors mathlib-bors bot closed this Aug 6, 2024
@mathlib-bors mathlib-bors bot deleted the eric-wieser/remove-ProofWidgets-again branch August 6, 2024 09:11
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
A bad merge in #11807 causes the change from #11877 (removing `import ProofWidgets`) to be reverted.
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
A bad merge in #11807 causes the change from #11877 (removing `import ProofWidgets`) to be reverted.
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
A bad merge in #11807 causes the change from #11877 (removing `import ProofWidgets`) to be reverted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants