[Merged by Bors] - chore(GroupTheory/Coset): deprecate some lemma#15482
Closed
astrainfinita wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - chore(GroupTheory/Coset): deprecate some lemma#15482astrainfinita wants to merge 3 commits intomasterfrom
astrainfinita wants to merge 3 commits intomasterfrom
Conversation
PR summary 138c3ae4ddImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
1 task
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 5, 2024
They were different in mathlib3 because of coercions.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
kbuzzard
reviewed
Aug 5, 2024
| @[to_additive (attr := elab_as_elim)] | ||
| theorem induction_on' {C : α ⧸ s → Prop} (x : α ⧸ s) (H : ∀ z : α, C z) : C x := | ||
| Quotient.inductionOn' x H | ||
| @[to_additive (attr := deprecated (since := "2024-08-04"))] alias induction_on' := induction_on |
Member
There was a problem hiding this comment.
I know this has been merged now but did we just lose an elab_as_elim attribute on the primed declaration?
Member
There was a problem hiding this comment.
Good catch, though it probably doesn't matter much since this is now deprecated.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
They were different in mathlib3 because of coercions.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
They were different in mathlib3 because of coercions.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
They were different in mathlib3 because of coercions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They were different in mathlib3 because of coercions.