[Merged by Bors] - refactor(Condensed): reorganize TopComparison#15401
Closed
dagurtomas wants to merge 9 commits intomasterfrom
Closed
[Merged by Bors] - refactor(Condensed): reorganize TopComparison#15401dagurtomas wants to merge 9 commits intomasterfrom
dagurtomas wants to merge 9 commits intomasterfrom
Conversation
PR summary 50e4da1b6b
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Condensed.TopComparison | 1587 | 1452 | -135 (-8.51%) |
| Mathlib.Condensed.TopCatAdjunction | 1591 | 1457 | -134 (-8.42%) |
| Mathlib.Condensed.Light.TopComparison | 1608 | 1473 | -135 (-8.40%) |
| Mathlib.Condensed.Light.TopCatAdjunction | 1612 | 1477 | -135 (-8.37%) |
Import changes for all files
| Files | Import difference |
|---|---|
3 filesMathlib.Condensed.TopComparison Mathlib.Condensed.Light.TopComparison Mathlib.Condensed.Light.TopCatAdjunction |
-135 |
Mathlib.Condensed.TopCatAdjunction |
-134 |
Declarations diff
+ TopCat.toSheafCompHausLike
+ topCatToSheafCompHausLike
- TopCat.toCondensedSet
- TopCat.toLightCondSet
- topCatToCondensedSet
- topCatToLightCondSet
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
4 tasks
|
This PR/issue depends on: |
Contributor
|
bors d+ As the variable inclusion has recently changed, it may be safer to sync with master. |
Contributor
|
✌️ dagurtomas can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
Define a general functor from `TopCat` to sheaves on `CompHausLike P` satisfying some properties, and redefine `topCatToCondensedSet` and `topCatToLightCondSet` in terms of that functor.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
YaelDillies
pushed a commit
that referenced
this pull request
Aug 14, 2024
Define a general functor from `TopCat` to sheaves on `CompHausLike P` satisfying some properties, and redefine `topCatToCondensedSet` and `topCatToLightCondSet` in terms of that functor.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
Define a general functor from `TopCat` to sheaves on `CompHausLike P` satisfying some properties, and redefine `topCatToCondensedSet` and `topCatToLightCondSet` in terms of that functor.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
Define a general functor from `TopCat` to sheaves on `CompHausLike P` satisfying some properties, and redefine `topCatToCondensedSet` and `topCatToLightCondSet` in terms of that functor.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
Define a general functor from `TopCat` to sheaves on `CompHausLike P` satisfying some properties, and redefine `topCatToCondensedSet` and `topCatToLightCondSet` in terms of that functor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define a general functor from
TopCatto sheaves onCompHausLike Psatisfying some properties, and redefinetopCatToCondensedSetandtopCatToLightCondSetin terms of that functor.This simplifies #15321, which the characterization of discrete condensed objects (#14027) depends on.