[Merged by Bors] - feat(ConditionallyCompleteLattice/Finset): ciSup_mem on list/multiset/finset by pechersky · Pull Request #15284 · leanprover-community/mathlib4

pechersky · 2024-07-30T02:28:53Z

As well as toDual_csSup
And simpler lemmas when on ConditionallyCompleteLinearOrderBot

depends on: [Merged by Bors] - feat(ConditionallyCompleteLattice): ciSup_image, ciSup_or', and other iSup-like lemmas #15271

… iSup-like lemmas

…/finset As well as toDual_csSup And simpler lemmas when on ConditionallyCompleteLinearOrderBot

github-actions · 2024-07-30T02:29:36Z

PR summary 3b386498e3

Import changes for modified files

No significant changes to the import graph

Import changes for all files

Files	Import difference

Declarations diff

+ Finset.Nonempty.ciSup_eq_max'_image
+ Finset.Nonempty.ciSup_mem_image
+ Finset.ciInf_eq_min'_image
+ Finset.ciInf_mem_image
+ Finset.ciSup_eq_max'_image
+ Finset.ciSup_mem_image
+ List.iInf_mem_map_of_exists_le_sInf_empty
+ List.iSup_mem_map_of_exists_sSup_empty_le
+ List.iSup_mem_map_of_ne_nil
+ Multiset.iInf_mem_map_of_exists_le_sInf_empty
+ Multiset.iSup_mem_map_of_exists_sSup_empty_le
+ Multiset.iSup_mem_map_of_ne_zero
+ Set.Finite.ciInf_mem_image
+ Set.Finite.ciSup_lt_iff
+ Set.Finite.ciSup_mem_image
+ Set.Finite.lt_ciInf_iff
+ Set.Nonempty.ciSup_lt_iff
+ Set.Nonempty.ciSup_mem_image

You can run this locally as follows

## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

ghost · 2024-08-05T10:02:27Z

This PR/issue depends on:

~~[Merged by Bors] - feat(ConditionallyCompleteLattice): ciSup_image, ciSup_or', and other iSup-like lemmas #15271~~
By Dependent Issues (🤖). Happy coding!

Mathlib/Order/ConditionallyCompleteLattice/Finset.lean

Ruben-VandeVelde

maintainer merge

github-actions · 2024-08-30T20:59:27Z

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

urkud · 2024-08-31T13:43:19Z

I think that some lemmas in this PR can be generalized. Please don't merge it yet. I'll write more in ~1h. Done.

Mathlib/Order/ConditionallyCompleteLattice/Basic.lean

Mathlib/Order/ConditionallyCompleteLattice/Finset.lean

…hub.com/leanprover-community/mathlib4 into pechersky/sup-conditional-big-operators

Vierkantor

Thanks!

bors d+

Mathlib/Order/ConditionallyCompleteLattice/Finset.lean

mathlib-bors · 2024-09-02T09:48:47Z

✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

pechersky · 2024-09-02T15:21:25Z

bors r+

…/finset (#15284) As well as toDual_csSup And simpler lemmas when on ConditionallyCompleteLinearOrderBot Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com> Co-authored-by: Yakov Pechersky <ffxen158@gmail.com> Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>

mathlib-bors · 2024-09-02T16:21:15Z

Pull request successfully merged into master.

Build succeeded:

…/finset (#15284) As well as toDual_csSup And simpler lemmas when on ConditionallyCompleteLinearOrderBot Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com> Co-authored-by: Yakov Pechersky <ffxen158@gmail.com> Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>

pechersky added 2 commits July 29, 2024 16:32

feat(ConditionallyCompleteLattice): ciSup_image, ciSup_or', and other…

798226a

… iSup-like lemmas

feat(ConditionallyCompleteLattice/Finset): ciSup_mem on list/multiset…

ecf3925

…/finset As well as toDual_csSup And simpler lemmas when on ConditionallyCompleteLinearOrderBot

pechersky mentioned this pull request Jul 30, 2024

[Merged by Bors] - feat(Analysis/Normed/{Group,Field}/Ultra): Nonarchimedean norms from ultrametrics #14768

Closed

3 tasks

ghost added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Jul 30, 2024

ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 5, 2024

Merge branch 'master' into pechersky/sup-conditional-big-operators

e06d3da

ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 6, 2024

pechersky added the t-order Order theory label Aug 6, 2024

ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 15, 2024

Merge branch 'master' into pechersky/sup-conditional-big-operators

dc88793

ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 16, 2024

Ruben-VandeVelde requested changes Aug 29, 2024

View reviewed changes

Ruben-VandeVelde added the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 29, 2024

feedback

5a00d7b

pechersky removed the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 29, 2024

Ruben-VandeVelde approved these changes Aug 30, 2024

View reviewed changes

github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 30, 2024

urkud self-assigned this Aug 31, 2024

urkud removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 31, 2024

Merge branch 'master' into pechersky/sup-conditional-big-operators

aebf5da

urkud reviewed Aug 31, 2024

View reviewed changes

Mathlib/Order/ConditionallyCompleteLattice/Basic.lean Outdated Show resolved Hide resolved

urkud reviewed Aug 31, 2024

View reviewed changes

Mathlib/Order/ConditionallyCompleteLattice/Finset.lean Outdated Show resolved Hide resolved

urkud added the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 31, 2024

pechersky added 2 commits September 1, 2024 16:16

remove existing lemmas

e02370c

generalize orderdual Sup lemmas out of complete lattice

427be39

pechersky added 3 commits September 1, 2024 16:19

remove now duplicate lemmas

467200d

use generalized lemmas

6480ca4

Merge branch 'pechersky/sup-conditional-big-operators' of https://git…

2a20649

…hub.com/leanprover-community/mathlib4 into pechersky/sup-conditional-big-operators

pechersky removed the awaiting-author A reviewer has asked the author a question or requested changes. label Sep 1, 2024

urkud removed their assignment Sep 1, 2024

Vierkantor approved these changes Sep 2, 2024

View reviewed changes

ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Sep 2, 2024

golf

3b38649

mathlib-bors bot changed the title ~~feat(ConditionallyCompleteLattice/Finset): ciSup_mem on list/multiset/finset~~ [Merged by Bors] - feat(ConditionallyCompleteLattice/Finset): ciSup_mem on list/multiset/finset Sep 2, 2024

mathlib-bors bot closed this Sep 2, 2024

mathlib-bors bot deleted the pechersky/sup-conditional-big-operators branch September 2, 2024 16:21

Conversation

pechersky commented Jul 30, 2024 • edited by Parcly-Taxel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR summary 3b386498e3

Import changes for modified files

Declarations diff

Uh oh!

ghost commented Aug 5, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

urkud commented Aug 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Vierkantor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mathlib-bors bot commented Sep 2, 2024

Uh oh!

pechersky commented Sep 2, 2024

Uh oh!

mathlib-bors bot commented Sep 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pechersky commented Jul 30, 2024 •

edited by Parcly-Taxel

Loading

github-actions bot commented Jul 30, 2024 •

edited

Loading

urkud commented Aug 31, 2024 •

edited

Loading