[Merged by Bors] - chore(Order/Filter/AtTopBot): Generalise from semilattices to directed orders#15252
Closed
YaelDillies wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - chore(Order/Filter/AtTopBot): Generalise from semilattices to directed orders#15252YaelDillies wants to merge 2 commits intomasterfrom
YaelDillies wants to merge 2 commits intomasterfrom
Conversation
…d orders Many lemmas requiring `[SemilatticeSup α]` actually only need `[Preorder α] [IsDirected α (· ≤ ·)]`.
PR summary 5f1da97cf4Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> |
Member
|
I see that you also moved lemmas around, which makes it harder to compare APIs. Are there any API changes other than |
Contributor
Author
|
No, except for the occasional dropping of |
Member
|
Thanks! 🎉 |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
…d orders (#15252) Many lemmas requiring `[SemilatticeSup α]` actually only need `[Preorder α] [IsDirected α (· ≤ ·)]`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
…d orders (#15252) Many lemmas requiring `[SemilatticeSup α]` actually only need `[Preorder α] [IsDirected α (· ≤ ·)]`.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
…d orders (#15252) Many lemmas requiring `[SemilatticeSup α]` actually only need `[Preorder α] [IsDirected α (· ≤ ·)]`.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
…d orders (#15252) Many lemmas requiring `[SemilatticeSup α]` actually only need `[Preorder α] [IsDirected α (· ≤ ·)]`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many lemmas requiring
[SemilatticeSup α]actually only need[Preorder α] [IsDirected α (· ≤ ·)].