[Merged by Bors] - chore: backports for leanprover/lean4#4814 (part 1)#15245
Closed
[Merged by Bors] - chore: backports for leanprover/lean4#4814 (part 1)#15245
Conversation
PR summary 5092be0756Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
This was referenced Jul 29, 2024
sgouezel
reviewed
Jul 29, 2024
Comment on lines
+954
to
+955
| section | ||
| variable [Decidable Q] |
Contributor
There was a problem hiding this comment.
This one looks wrong, you're just adding an assumption.
Contributor
Author
There was a problem hiding this comment.
Previously we were using an explicit Decidable P, and the classical decidable instance for Q. Surely this is not what was intended?
Contributor
There was a problem hiding this comment.
Thanks for the explanation, I had not noticed the attribute [local instance 10] Classical.propDecidable at the beginning of the file (which we should probably remove, but that's for another PR).
Rida-Hamadani
pushed a commit
that referenced
this pull request
Jul 29, 2024
This was referenced Jul 30, 2024
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
see #15245 Co-authored-by: Kim Morrison <kim@tqft.net>
Contributor
|
bors d+ |
Contributor
|
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
See #15245 Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Contributor
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
The new variables inclusion mechanism leanprover/lean4#4814 is going to require many changes to Mathlib. Some of these changes are to make sure typeclass hypotheses are not unnecessarily included. This is achieved either by using `section` to bound `variable [...]`, using `variable ... in`, or reordering theorems. (I think you can see all three being using here.) Other changes require adding `include ...` to include variables that the new mechanism won't automatically include. These changes can't be backported to master, and instead are accumulating on the `lean-pr-testing-4814` branch.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
see #15245 Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
see #15245 Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
see #15245 Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
See #15245 Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
The new variables inclusion mechanism leanprover/lean4#4814 is going to require many changes to Mathlib. Some of these changes are to make sure typeclass hypotheses are not unnecessarily included. This is achieved either by using `section` to bound `variable [...]`, using `variable ... in`, or reordering theorems. (I think you can see all three being using here.) Other changes require adding `include ...` to include variables that the new mechanism won't automatically include. These changes can't be backported to master, and instead are accumulating on the `lean-pr-testing-4814` branch.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
see #15245 Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
see #15245 Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
see #15245 Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
see #15245 Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
see #15245 Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
See #15245 Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
The new variables inclusion mechanism leanprover/lean4#4814 is going to require many changes to Mathlib. Some of these changes are to make sure typeclass hypotheses are not unnecessarily included. This is achieved either by using `section` to bound `variable [...]`, using `variable ... in`, or reordering theorems. (I think you can see all three being using here.) Other changes require adding `include ...` to include variables that the new mechanism won't automatically include. These changes can't be backported to master, and instead are accumulating on the `lean-pr-testing-4814` branch.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
see #15245 Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
see #15245 Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
see #15245 Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new variables inclusion mechanism leanprover/lean4#4814 is going to require many changes to Mathlib.
Some of these changes are to make sure typeclass hypotheses are not unnecessarily included. This is achieved either by using
sectionto boundvariable [...], usingvariable ... in, or reordering theorems. (I think you can see all three being using here.)Other changes require adding
include ...to include variables that the new mechanism won't automatically include. These changes can't be backported to master, and instead are accumulating on thelean-pr-testing-4814branch.