Skip to content

[Merged by Bors] - feat(FieldTheory/Adjoin): add some results of extendScalars#15238

Closed
acmepjz wants to merge 8 commits intomasterfrom
acmepjz_extendScalars_bot
Closed

[Merged by Bors] - feat(FieldTheory/Adjoin): add some results of extendScalars#15238
acmepjz wants to merge 8 commits intomasterfrom
acmepjz_extendScalars_bot

Conversation

@acmepjz
Copy link
Copy Markdown
Collaborator

@acmepjz acmepjz commented Jul 28, 2024 •
edited
Loading

  • extendScalars_{self|top|inf|sup} for intermediate fields and subfields
  • also add restrictScalars_{inf|sup} and bot_toSubfield
  • add a missing helper lemma toSubfield_injective

Open in Gitpod

@acmepjz acmepjz added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-algebra Algebra (groups, rings, fields, etc) labels Jul 28, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 28, 2024 •
edited
Loading

PR summary 074ecc62e5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ bot_toSubfield
+ restrictScalars_inf
+ restrictScalars_sup
+ toSubfield_injective
++ extendScalars_inf
++ extendScalars_self
++ extendScalars_sup
++ extendScalars_top

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@ghost ghost added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jul 28, 2024
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jul 28, 2024
@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 31, 2024
@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 31, 2024
@acmepjz acmepjz mentioned this pull request Jul 31, 2024
Closed
3 tasks
@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 21, 2024
@acmepjz acmepjz added the awaiting-author A reviewer has asked the author a question or requested changes. label Sep 3, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Oct 16, 2024
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

mathlib4-dependent-issues-bot commented Oct 16, 2024

This PR/issue depends on:

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 16, 2024
@acmepjz acmepjz changed the title feat(FieldTheory/{IntermediateField|Adjoin}): add some results of extendScalars feat(FieldTheory/Adjoin): add some results of extendScalars Oct 16, 2024
@acmepjz acmepjz removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 16, 2024
@erdOne
Copy link
Copy Markdown
Member

erdOne commented Oct 17, 2024

LGTM thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 17, 2024

🚀 Pull request has been placed on the maintainer queue by erdOne.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Oct 17, 2024
jcommelin
jcommelin reviewed Oct 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Oct 17, 2024
@acmepjz
Copy link
Copy Markdown
Collaborator Author

acmepjz commented Oct 18, 2024

It's waiting in queue for a whole day...

@erdOne
Copy link
Copy Markdown
Member

erdOne commented Oct 18, 2024

This is very strange. It is not in a queue here I'll ask in the reviewer stream on Zulip.

@bryangingechen
Copy link
Copy Markdown
Contributor

bryangingechen commented Oct 18, 2024

Thanks for pinging on Zulip. Yes, this probably fell off the queue when bors crashed yesterday.
bors r+

Just in case something else happens:
bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 18, 2024

✌️ acmepjz can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Oct 18, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 18, 2024
@acmepjz
feat(FieldTheory/Adjoin): add some results of extendScalars (#15238)
f826d22 
- `extendScalars_{self|top|inf|sup}` for intermediate fields and subfields
- also add `restrictScalars_{inf|sup}` and `bot_toSubfield`
- add a missing helper lemma `toSubfield_injective`
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 18, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Oct 18, 2024
@acmepjz
feat(FieldTheory/Adjoin): add some results of extendScalars (#15238)
77b74ca 
- `extendScalars_{self|top|inf|sup}` for intermediate fields and subfields
- also add `restrictScalars_{inf|sup}` and `bot_toSubfield`
- add a missing helper lemma `toSubfield_injective`
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 18, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Oct 18, 2024
@acmepjz
feat(FieldTheory/Adjoin): add some results of extendScalars (#15238)
9e3fa1e 
- `extendScalars_{self|top|inf|sup}` for intermediate fields and subfields
- also add `restrictScalars_{inf|sup}` and `bot_toSubfield`
- add a missing helper lemma `toSubfield_injective`
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 18, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(FieldTheory/Adjoin): add some results of extendScalars [Merged by Bors] - feat(FieldTheory/Adjoin): add some results of extendScalars Oct 18, 2024
@mathlib-bors mathlib-bors bot closed this Oct 18, 2024
@mathlib-bors mathlib-bors bot deleted the acmepjz_extendScalars_bot branch October 18, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@acmepjz @mathlib4-dependent-issues-bot @erdOne @bryangingechen @jcommelin @leanprover-community-bot-assistant