[Merged by Bors] - chore(Data.NNRat.Defs): split file into unbundled and bundled ordered algebra #15072
Closed
mattrobball wants to merge 10 commits intomasterfrom
Closed
[Merged by Bors] - chore(Data.NNRat.Defs): split file into unbundled and bundled ordered algebra #15072mattrobball wants to merge 10 commits intomasterfrom
mattrobball wants to merge 10 commits intomasterfrom
Conversation
PR summary ca3cf68ae8
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Data.NNRat.Defs | 458 | 425 | -33 (-7.21%) |
| Mathlib.Tactic.Positivity.Basic | 488 | 484 | -4 (-0.82%) |
Import changes for all files
| Files | Import difference |
|---|---|
4 filesMathlib.Algebra.Field.Rat Mathlib.Data.NNRat.Defs Mathlib.Algebra.Module.LinearMap.Rat Mathlib.Algebra.Module.Rat |
-33 |
11 filesMathlib.CategoryTheory.Monoidal.Linear Mathlib.Algebra.Category.ModuleCat.Monoidal.Symmetric Mathlib.Algebra.Category.ModuleCat.Monoidal.Basic Mathlib.CategoryTheory.Quotient.Linear Mathlib.Algebra.Homology.ShortComplex.Linear Mathlib.RepresentationTheory.Action.Monoidal Mathlib.RepresentationTheory.Action.Limits Mathlib.Algebra.Category.ModuleCat.Monoidal.Closed Mathlib.CategoryTheory.Monoidal.Subcategory Mathlib.Algebra.Homology.Linear Mathlib.CategoryTheory.Linear.LinearFunctor |
-27 |
8 filesMathlib.Data.Int.AbsoluteValue Mathlib.Tactic.Positivity Mathlib.Algebra.Order.EuclideanAbsoluteValue Mathlib.Algebra.Order.Hom.Basic Mathlib.Topology.UniformSpace.AbsoluteValue Mathlib.Tactic.Positivity.Basic Mathlib.Algebra.Order.CauSeq.Basic Mathlib.Algebra.Order.AbsoluteValue |
-4 |
8 filesMathlib.Combinatorics.SimpleGraph.Triangle.Removal Mathlib.Tactic.Positivity.Finset Mathlib.Combinatorics.Additive.DoublingConst Mathlib.Combinatorics.Additive.Corner.Roth Mathlib.Combinatorics.SimpleGraph.Triangle.Basic Mathlib.Data.Finset.Density Mathlib.Combinatorics.SimpleGraph.Triangle.Tripartite Mathlib.Tactic |
1 |
Mathlib.Data.NNRat.Order |
454 |
Declarations diff
+ Rat.instPosMulMono
+ Rat.instZeroLEOneClass
+ nonpos_iff_eq_zero
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
…ed algebra results Author: Matthew Ballard <matt@mrb.email> Date: Fri Aug 9 13:48:05 2024 -0400
a562abe to
24cf15b
Compare
1 task
|
This PR/issue depends on: |
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 24cf15b. |
j-loreaux
reviewed
Aug 20, 2024
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Contributor
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
… algebra (#15072) We split off the `CanonicallyOrderedCommSemiring`, `CanonicallyLinearOrderedAddCommMonoid`, and `OrderedSub` instances on `NNRat` to `Data.NNRat.Order` leaving the remainder independent of bundled ordered algebra classes. Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
… algebra (#15072) We split off the `CanonicallyOrderedCommSemiring`, `CanonicallyLinearOrderedAddCommMonoid`, and `OrderedSub` instances on `NNRat` to `Data.NNRat.Order` leaving the remainder independent of bundled ordered algebra classes. Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
… algebra (#15072) We split off the `CanonicallyOrderedCommSemiring`, `CanonicallyLinearOrderedAddCommMonoid`, and `OrderedSub` instances on `NNRat` to `Data.NNRat.Order` leaving the remainder independent of bundled ordered algebra classes. Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
… algebra (#15072) We split off the `CanonicallyOrderedCommSemiring`, `CanonicallyLinearOrderedAddCommMonoid`, and `OrderedSub` instances on `NNRat` to `Data.NNRat.Order` leaving the remainder independent of bundled ordered algebra classes. Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We split off the
CanonicallyOrderedCommSemiring,CanonicallyLinearOrderedAddCommMonoid, andOrderedSubinstances onNNRattoData.NNRat.Orderleaving the remainder independent of bundled ordered algebra classes.