Skip to content

[Merged by Bors] - Feat: add a FunLike and an EmbeddingLike instance#1488

Closed
urkud wants to merge 1 commit intomasterfrom
YK-emb-like
Closed

[Merged by Bors] - Feat: add a FunLike and an EmbeddingLike instance#1488
urkud wants to merge 1 commit intomasterfrom
YK-emb-like

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Jan 11, 2023

@kbuzzard
Copy link
Copy Markdown
Member

Is there a corresponding mathlib3 PR for this mathlib4 PR? Right now the idea is that we keep the two repos in sync unless there are things in mathlib3 which don't work any more in mathlib4, right?

@urkud urkud added the mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged label Jan 17, 2023
@urkud
Copy link
Copy Markdown
Member Author

urkud commented Jan 17, 2023

Is there a corresponding mathlib3 PR for this mathlib4 PR? Right now the idea is that we keep the two repos in sync unless there are things in mathlib3 which don't work any more in mathlib4, right?

Backported.

@fpvandoorn
Copy link
Copy Markdown
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jan 25, 2023
bors bot pushed a commit that referenced this pull request Jan 25, 2023
bors bot pushed a commit to leanprover-community/mathlib3 that referenced this pull request Jan 25, 2023
@bors
Copy link
Copy Markdown

bors bot commented Jan 25, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Feat: add a FunLike and an EmbeddingLike instance [Merged by Bors] - Feat: add a FunLike and an EmbeddingLike instance Jan 25, 2023
@bors bors bot closed this Jan 25, 2023
@bors bors bot deleted the YK-emb-like branch January 25, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants